Unverified Commit 80f921ba authored by Cyrus Leung's avatar Cyrus Leung Committed by GitHub
Browse files

[Bugfix] Fix `normalize` still being passed to `PoolerConfig` (#33794)


Signed-off-by: default avatarDarkLight1337 <tlleungac@connect.ust.hk>
parent 711edaf0
...@@ -54,7 +54,7 @@ def test_models( ...@@ -54,7 +54,7 @@ def test_models(
vllm_extra_kwargs = {} vllm_extra_kwargs = {}
if model == "ssmits/Qwen2-7B-Instruct-embed-base": if model == "ssmits/Qwen2-7B-Instruct-embed-base":
vllm_extra_kwargs["pooler_config"] = PoolerConfig( vllm_extra_kwargs["pooler_config"] = PoolerConfig(
seq_pooling_type="MEAN", normalize=False seq_pooling_type="MEAN", use_activation=False
) )
max_model_len: int | None = 512 max_model_len: int | None = 512
......
...@@ -174,8 +174,8 @@ class LLM: ...@@ -174,8 +174,8 @@ class LLM:
multi-modal processor obtained from `AutoProcessor.from_pretrained`. multi-modal processor obtained from `AutoProcessor.from_pretrained`.
The available overrides depend on the model that is being run. The available overrides depend on the model that is being run.
For example, for Phi-3-Vision: `{"num_crops": 4}`. For example, for Phi-3-Vision: `{"num_crops": 4}`.
pooler_config: Initialize non-default pooling config for the pooling pooler_config: Initialize non-default pooling config for the pooling model,
model. e.g. `PoolerConfig(seq_pooling_type="MEAN", normalize=False)`. e.g., `PoolerConfig(seq_pooling_type="MEAN", use_activation=False)`.
compilation_config: Either an integer or a dictionary. If it is an compilation_config: Either an integer or a dictionary. If it is an
integer, it is used as the mode of compilation optimization. If it integer, it is used as the mode of compilation optimization. If it
is a dictionary, it can specify the full compilation configuration. is a dictionary, it can specify the full compilation configuration.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment