Unverified Commit 68311891 authored by Harry Mellor's avatar Harry Mellor Committed by GitHub
Browse files

Don't default construct `ModelConfig` when default constructing `VllmConfig` (#17943)


Signed-off-by: default avatarHarry Mellor <19981378+hmellor@users.noreply.github.com>
parent fc4441a4
......@@ -3954,7 +3954,9 @@ class VllmConfig:
simplifies passing around the distinct configurations in the codebase.
"""
model_config: ModelConfig = field(default_factory=ModelConfig)
# TODO: use default_factory once default constructing ModelConfig doesn't
# try to download a model
model_config: ModelConfig = None # type: ignore
"""Model configuration."""
cache_config: CacheConfig = field(default_factory=CacheConfig)
"""Cache configuration."""
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment