"tests/vscode:/vscode.git/clone" did not exist on "07b8fae219b1fff51ef115c38c44b51395be5bb5"
Unverified Commit 6024d115 authored by Ashwin Phadke's avatar Ashwin Phadke Committed by GitHub
Browse files

Lora bias(enable_lora_bias) deprecate warning (#24339)


Signed-off-by: default avatarJee Jee Li <pandaleefree@gmail.com>
Co-authored-by: default avatarJee Jee Li <pandaleefree@gmail.com>
parent 7555d6b3
...@@ -2458,7 +2458,6 @@ class LoRAConfig: ...@@ -2458,7 +2458,6 @@ class LoRAConfig:
LoRA adapter. Will be removed in v0.12.0.""" LoRA adapter. Will be removed in v0.12.0."""
lora_vocab_padding_size: ClassVar[int] = current_platform\ lora_vocab_padding_size: ClassVar[int] = current_platform\
.get_lora_vocab_padding_size() .get_lora_vocab_padding_size()
default_mm_loras: Optional[dict[str, str]] = None default_mm_loras: Optional[dict[str, str]] = None
"""Dictionary mapping specific modalities to LoRA model paths; this field """Dictionary mapping specific modalities to LoRA model paths; this field
is only applicable to multimodal models and should be leveraged when a is only applicable to multimodal models and should be leveraged when a
...@@ -2470,7 +2469,8 @@ class LoRAConfig: ...@@ -2470,7 +2469,8 @@ class LoRAConfig:
will be automatically assigned to 1-n with the names of the modalities will be automatically assigned to 1-n with the names of the modalities
in alphabetic order.""" in alphabetic order."""
bias_enabled: bool = False bias_enabled: bool = False
"""Enable bias for LoRA adapters.""" """[DEPRECATED] Enable bias for LoRA adapters. This option will be
removed in v0.12.0."""
def compute_hash(self) -> str: def compute_hash(self) -> str:
""" """
...@@ -2503,6 +2503,11 @@ class LoRAConfig: ...@@ -2503,6 +2503,11 @@ class LoRAConfig:
"in v0.12.0. Additional vocabulary support for " "in v0.12.0. Additional vocabulary support for "
"LoRA adapters is being phased out.") "LoRA adapters is being phased out.")
# Deprecation warning for enable_lora_bias
if self.bias_enabled:
logger.warning("`enable_lora_bias` is deprecated "
"and will be removed in v0.12.0.")
# Setting the maximum rank to 512 should be able to satisfy the vast # Setting the maximum rank to 512 should be able to satisfy the vast
# majority of applications. # majority of applications.
possible_max_ranks = (8, 16, 32, 64, 128, 256, 320, 512) possible_max_ranks = (8, 16, 32, 64, 128, 256, 320, 512)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment