Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
51931c5c
Unverified
Commit
51931c5c
authored
Jan 24, 2026
by
Cyrus Leung
Committed by
GitHub
Jan 24, 2026
Browse files
[UX] Deduplicate sampling parameter startup logs (#32953)
Signed-off-by:
DarkLight1337
<
tlleungac@connect.ust.hk
>
parent
06b557ec
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
14 additions
and
34 deletions
+14
-34
vllm/config/model.py
vllm/config/model.py
+11
-9
vllm/entrypoints/openai/chat_completion/serving.py
vllm/entrypoints/openai/chat_completion/serving.py
+0
-8
vllm/entrypoints/openai/completion/serving.py
vllm/entrypoints/openai/completion/serving.py
+2
-9
vllm/entrypoints/openai/responses/serving.py
vllm/entrypoints/openai/responses/serving.py
+1
-8
No files found.
vllm/config/model.py
View file @
51931c5c
...
...
@@ -1339,10 +1339,9 @@ class ModelConfig:
Returns:
A dictionary containing the non-default sampling parameters.
"""
if
self
.
generation_config
==
"vllm"
:
config
=
{}
else
:
config
=
self
.
try_get_generation_config
()
src
=
self
.
generation_config
config
=
{}
if
src
==
"vllm"
else
self
.
try_get_generation_config
()
# Overriding with given generation config
config
.
update
(
self
.
override_generation_config
)
...
...
@@ -1368,13 +1367,16 @@ class ModelConfig:
else
:
diff_sampling_param
=
{}
if
diff_sampling_param
:
if
diff_sampling_param
and
src
!=
"vllm"
:
logger
.
warning_once
(
"Default sampling parameters have been overridden by the "
"model's Hugging Face generation config recommended from the "
"model creator. If this is not intended, please relaunch "
"vLLM instance with `--generation-config vllm`."
"Default vLLM sampling parameters have been overridden by %s: `%s`. "
"If this is not intended, please relaunch vLLM instance "
"with `--generation-config vllm`."
,
"the model's `generation_config.json`"
if
src
==
"auto"
else
src
,
str
(
diff_sampling_param
),
scope
=
"local"
,
)
return
diff_sampling_param
@
property
...
...
vllm/entrypoints/openai/chat_completion/serving.py
View file @
51931c5c
...
...
@@ -143,14 +143,6 @@ class OpenAIServingChat(OpenAIServing):
self
.
enable_prompt_tokens_details
=
enable_prompt_tokens_details
self
.
enable_force_include_usage
=
enable_force_include_usage
self
.
default_sampling_params
=
self
.
model_config
.
get_diff_sampling_param
()
if
self
.
default_sampling_params
:
source
=
self
.
model_config
.
generation_config
source
=
"model"
if
source
==
"auto"
else
source
logger
.
info
(
"Using default chat sampling params from %s: %s"
,
source
,
self
.
default_sampling_params
,
)
if
self
.
model_config
.
hf_config
.
model_type
==
"kimi_k2"
:
self
.
tool_call_id_type
=
"kimi_k2"
else
:
...
...
vllm/entrypoints/openai/completion/serving.py
View file @
51931c5c
...
...
@@ -72,16 +72,9 @@ class OpenAIServingCompletion(OpenAIServing):
self
.
logits_processors
=
self
.
model_config
.
logits_processors
self
.
enable_prompt_tokens_details
=
enable_prompt_tokens_details
self
.
default_sampling_params
=
self
.
model_config
.
get_diff_sampling_param
()
self
.
enable_force_include_usage
=
enable_force_include_usage
if
self
.
default_sampling_params
:
source
=
self
.
model_config
.
generation_config
source
=
"model"
if
source
==
"auto"
else
source
logger
.
info
(
"Using default completion sampling params from %s: %s"
,
source
,
self
.
default_sampling_params
,
)
self
.
default_sampling_params
=
self
.
model_config
.
get_diff_sampling_param
()
async
def
render_completion_request
(
self
,
...
...
vllm/entrypoints/openai/responses/serving.py
View file @
51931c5c
...
...
@@ -221,15 +221,8 @@ class OpenAIServingResponses(OpenAIServing):
)
self
.
enable_prompt_tokens_details
=
enable_prompt_tokens_details
self
.
enable_force_include_usage
=
enable_force_include_usage
self
.
default_sampling_params
=
self
.
model_config
.
get_diff_sampling_param
()
if
self
.
default_sampling_params
:
source
=
self
.
model_config
.
generation_config
source
=
"model"
if
source
==
"auto"
else
source
logger
.
info
(
"Using default chat sampling params from %s: %s"
,
source
,
self
.
default_sampling_params
,
)
# If False (default), the "store" option is (silently) ignored and the
# response is not stored. If True, the response is stored in memory.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment