Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
516c3f78
Unverified
Commit
516c3f78
authored
Nov 25, 2025
by
Thomas Parnell
Committed by
GitHub
Nov 25, 2025
Browse files
[Bugfix] Fix logic for choosing default prefix caching setting (#29393)
Signed-off-by:
Thomas Parnell
<
tpa@zurich.ibm.com
>
parent
51fc9e01
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
2 deletions
+7
-2
tests/engine/test_arg_utils.py
tests/engine/test_arg_utils.py
+2
-1
vllm/engine/arg_utils.py
vllm/engine/arg_utils.py
+5
-1
No files found.
tests/engine/test_arg_utils.py
View file @
516c3f78
...
@@ -277,8 +277,9 @@ def test_prefix_cache_default():
...
@@ -277,8 +277,9 @@ def test_prefix_cache_default():
parser
=
EngineArgs
.
add_cli_args
(
FlexibleArgumentParser
())
parser
=
EngineArgs
.
add_cli_args
(
FlexibleArgumentParser
())
args
=
parser
.
parse_args
([])
args
=
parser
.
parse_args
([])
# should be None by default (depends on model).
engine_args
=
EngineArgs
.
from_cli_args
(
args
=
args
)
engine_args
=
EngineArgs
.
from_cli_args
(
args
=
args
)
assert
engine_args
.
enable_prefix_caching
,
"prefix caching should default to on."
assert
engine_args
.
enable_prefix_caching
is
None
# with flag to turn it on.
# with flag to turn it on.
args
=
parser
.
parse_args
([
"--enable-prefix-caching"
])
args
=
parser
.
parse_args
([
"--enable-prefix-caching"
])
...
...
vllm/engine/arg_utils.py
View file @
516c3f78
...
@@ -880,7 +880,11 @@ class EngineArgs:
...
@@ -880,7 +880,11 @@ class EngineArgs:
"--num-gpu-blocks-override"
,
**
cache_kwargs
[
"num_gpu_blocks_override"
]
"--num-gpu-blocks-override"
,
**
cache_kwargs
[
"num_gpu_blocks_override"
]
)
)
cache_group
.
add_argument
(
cache_group
.
add_argument
(
"--enable-prefix-caching"
,
**
cache_kwargs
[
"enable_prefix_caching"
]
"--enable-prefix-caching"
,
**
{
**
cache_kwargs
[
"enable_prefix_caching"
],
"default"
:
None
,
},
)
)
cache_group
.
add_argument
(
cache_group
.
add_argument
(
"--prefix-caching-hash-algo"
,
**
cache_kwargs
[
"prefix_caching_hash_algo"
]
"--prefix-caching-hash-algo"
,
**
cache_kwargs
[
"prefix_caching_hash_algo"
]
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment