"vscode:/vscode.git/clone" did not exist on "7a0b011dd51e5c6b48e8f8f5424be0995b5cb8ee"
Unverified Commit 4b7f5ea1 authored by omerpaz95's avatar omerpaz95 Committed by GitHub
Browse files

[KV Connector] Allow metrics of multiple connectors of same types in multi connector. (#40010)


Signed-off-by: default avataromerpaz95 <omerpaz95@gmail.com>
Co-authored-by: default avatarOr Ozeri <oro@il.ibm.com>
parent 38907e43
...@@ -548,7 +548,13 @@ class MultiConnector(KVConnectorBase_V1): ...@@ -548,7 +548,13 @@ class MultiConnector(KVConnectorBase_V1):
if stats_by_connector is None: if stats_by_connector is None:
# Lazy init to allow optional return value. # Lazy init to allow optional return value.
stats_by_connector = MultiKVConnectorStats() stats_by_connector = MultiKVConnectorStats()
stats_by_connector[c.__class__.__name__] = stats connector_id = c.__class__.__name__
if connector_id in stats_by_connector.data:
stats_by_connector[connector_id] = stats_by_connector[
connector_id
].aggregate(stats)
else:
stats_by_connector[connector_id] = stats
return stats_by_connector return stats_by_connector
@classmethod @classmethod
...@@ -560,9 +566,13 @@ class MultiConnector(KVConnectorBase_V1): ...@@ -560,9 +566,13 @@ class MultiConnector(KVConnectorBase_V1):
per_engine_labelvalues: dict[int, list[object]], per_engine_labelvalues: dict[int, list[object]],
) -> KVConnectorPromMetrics: ) -> KVConnectorPromMetrics:
prom_metrics: dict[str, KVConnectorPromMetrics] = {} prom_metrics: dict[str, KVConnectorPromMetrics] = {}
seen_classes: set[type] = set()
for connector_cls, temp_config in cls._get_connector_classes_and_configs( for connector_cls, temp_config in cls._get_connector_classes_and_configs(
vllm_config vllm_config
): ):
if connector_cls in seen_classes:
continue
seen_classes.add(connector_cls)
connector_prom = connector_cls.build_prom_metrics( connector_prom = connector_cls.build_prom_metrics(
temp_config, metric_types, labelnames, per_engine_labelvalues temp_config, metric_types, labelnames, per_engine_labelvalues
) )
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment