"vllm/vscode:/vscode.git/clone" did not exist on "84f6cd741b591c780b6f5ac9be05413fd50812db"
Unverified Commit 4b59f00e authored by Nick Hill's avatar Nick Hill Committed by GitHub
Browse files

[Fix] Fix best_of behavior when n=1 (#3298)

parent 9e8744a5
...@@ -87,12 +87,12 @@ class RequestOutput: ...@@ -87,12 +87,12 @@ class RequestOutput:
@classmethod @classmethod
def from_seq_group(cls, seq_group: SequenceGroup) -> "RequestOutput": def from_seq_group(cls, seq_group: SequenceGroup) -> "RequestOutput":
# Get the top-n sequences.
n = seq_group.sampling_params.n
seqs = seq_group.get_seqs() seqs = seq_group.get_seqs()
if n == 1: if len(seqs) == 1:
top_n_seqs = seqs top_n_seqs = seqs
else: else:
# Get the top-n sequences.
n = seq_group.sampling_params.n
if seq_group.sampling_params.use_beam_search: if seq_group.sampling_params.use_beam_search:
sorting_key = lambda seq: seq.get_beam_search_score( sorting_key = lambda seq: seq.get_beam_search_score(
seq_group.sampling_params.length_penalty) seq_group.sampling_params.length_penalty)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment