Unverified Commit 4b1ff132 authored by Wentao Ye's avatar Wentao Ye Committed by GitHub
Browse files

[Feature] Default `ignore_eos` True for `random` dataset (#28227)


Signed-off-by: default avataryewentao256 <zhyanwentao@126.com>
parent e0d6b4a8
...@@ -1359,6 +1359,14 @@ async def main_async(args: argparse.Namespace) -> dict[str, Any]: ...@@ -1359,6 +1359,14 @@ async def main_async(args: argparse.Namespace) -> dict[str, Any]:
"'--dataset-path' if required." "'--dataset-path' if required."
) )
# when using random datasets, default to ignoring EOS
# so generation runs to the requested length
if (
args.dataset_name in ("random", "random-mm")
and args.backend in OPENAI_COMPATIBLE_BACKENDS
):
args.ignore_eos = True
# Load the dataset. # Load the dataset.
input_requests = get_samples(args, tokenizer) input_requests = get_samples(args, tokenizer)
goodput_config_dict = check_goodput_args(args) goodput_config_dict = check_goodput_args(args)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment