Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
4708f13a
Unverified
Commit
4708f13a
authored
Apr 04, 2025
by
Michael Goin
Committed by
GitHub
Apr 04, 2025
Browse files
[Bugfix] Fix default behavior/fallback for pp in v1 (#16057)
Signed-off-by:
mgoin
<
mgoin64@gmail.com
>
parent
a6d042df
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
2 deletions
+3
-2
vllm/engine/arg_utils.py
vllm/engine/arg_utils.py
+3
-2
No files found.
vllm/engine/arg_utils.py
View file @
4708f13a
...
...
@@ -1521,8 +1521,9 @@ class EngineArgs:
# PP is supported on V1 with Ray distributed executor,
# but off for MP distributed executor for now.
if
(
self
.
pipeline_parallel_size
>
1
and
self
.
distributed_executor_backend
==
"mp"
and
_warn_or_fallback
(
"PP (MP distributed executor)"
)):
and
self
.
distributed_executor_backend
!=
"ray"
):
name
=
"Pipeline Parallelism without Ray distributed executor"
_raise_or_fallback
(
feature_name
=
name
,
recommend_to_remove
=
False
)
return
False
# ngram is supported on V1, but off by default for now.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment