Unverified Commit 33fc1e2e authored by Robert Shaw's avatar Robert Shaw Committed by GitHub
Browse files

[Frontend] Improve `StreamingResponse` Exception Handling (#11752)

parent eba17173
...@@ -301,7 +301,7 @@ class OpenAIServingChat(OpenAIServing): ...@@ -301,7 +301,7 @@ class OpenAIServingChat(OpenAIServing):
] * num_choices ] * num_choices
else: else:
tool_parsers = [None] * num_choices tool_parsers = [None] * num_choices
except RuntimeError as e: except Exception as e:
logger.exception("Error in tool parser creation.") logger.exception("Error in tool parser creation.")
data = self.create_streaming_error_response(str(e)) data = self.create_streaming_error_response(str(e))
yield f"data: {data}\n\n" yield f"data: {data}\n\n"
...@@ -591,7 +591,7 @@ class OpenAIServingChat(OpenAIServing): ...@@ -591,7 +591,7 @@ class OpenAIServingChat(OpenAIServing):
completion_tokens=num_completion_tokens, completion_tokens=num_completion_tokens,
total_tokens=num_prompt_tokens + num_completion_tokens) total_tokens=num_prompt_tokens + num_completion_tokens)
except ValueError as e: except Exception as e:
# TODO: Use a vllm-specific Validation Error # TODO: Use a vllm-specific Validation Error
logger.exception("Error in chat completion stream generator.") logger.exception("Error in chat completion stream generator.")
data = self.create_streaming_error_response(str(e)) data = self.create_streaming_error_response(str(e))
......
...@@ -371,7 +371,7 @@ class OpenAIServingCompletion(OpenAIServing): ...@@ -371,7 +371,7 @@ class OpenAIServingCompletion(OpenAIServing):
# report to FastAPI middleware aggregate usage across all choices # report to FastAPI middleware aggregate usage across all choices
request_metadata.final_usage_info = final_usage_info request_metadata.final_usage_info = final_usage_info
except ValueError as e: except Exception as e:
# TODO: Use a vllm-specific Validation Error # TODO: Use a vllm-specific Validation Error
data = self.create_streaming_error_response(str(e)) data = self.create_streaming_error_response(str(e))
yield f"data: {data}\n\n" yield f"data: {data}\n\n"
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment