"benchmarks/vscode:/vscode.git/clone" did not exist on "eb0fa43868cf77e8eb2bdd563f8370b3c6bb00e2"
Unverified Commit 2abbd351 authored by 22quinn's avatar 22quinn Committed by GitHub
Browse files

[Core] Enable async scheduling for external_launcher mode (#27394)


Signed-off-by: default avatar22quinn <33176974+22quinn@users.noreply.github.com>
Co-authored-by: default avatarZhuohan Li <zhuohan123@gmail.com>
parent 446912d1
...@@ -1553,11 +1553,12 @@ class EngineArgs: ...@@ -1553,11 +1553,12 @@ class EngineArgs:
) )
if self.async_scheduling and ( if self.async_scheduling and (
parallel_config.distributed_executor_backend not in ("mp", "uni") parallel_config.distributed_executor_backend
not in ("mp", "uni", "external_launcher")
): ):
raise ValueError( raise ValueError(
"Currently, async scheduling only supports `mp` or `uni` " "Currently, async scheduling only supports `mp`, `uni` or "
"distributed executor backend, but you choose " "`external_launcher` distributed executor backend, but you choose "
f"`{parallel_config.distributed_executor_backend}`." f"`{parallel_config.distributed_executor_backend}`."
) )
......
...@@ -306,9 +306,7 @@ class LLMEngine: ...@@ -306,9 +306,7 @@ class LLMEngine:
self.engine_core.abort_requests(processed_outputs.reqs_to_abort) self.engine_core.abort_requests(processed_outputs.reqs_to_abort)
# 4) Record stats # 4) Record stats
if self.logger_manager is not None: if self.logger_manager is not None and outputs.scheduler_stats is not None:
assert outputs.scheduler_stats is not None
self.logger_manager.record( self.logger_manager.record(
scheduler_stats=outputs.scheduler_stats, scheduler_stats=outputs.scheduler_stats,
iteration_stats=iteration_stats, iteration_stats=iteration_stats,
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment