Unverified Commit 26a46558 authored by Nicolò Lucchesi's avatar Nicolò Lucchesi Committed by GitHub
Browse files

[NIXL] Use config to enable telemetry + NIXL version bump (#29305)


Signed-off-by: default avatarNickLucche <nlucches@redhat.com>
parent e924bbb4
lmcache lmcache
nixl >= 0.6.0 # Required for disaggregated prefill nixl >= 0.7.1 # Required for disaggregated prefill
...@@ -4,7 +4,6 @@ import contextlib ...@@ -4,7 +4,6 @@ import contextlib
import copy import copy
import logging import logging
import math import math
import os
import queue import queue
import threading import threading
import time import time
...@@ -810,9 +809,6 @@ class NixlConnectorWorker: ...@@ -810,9 +809,6 @@ class NixlConnectorWorker:
self.nixl_backends = vllm_config.kv_transfer_config.get_from_extra_config( self.nixl_backends = vllm_config.kv_transfer_config.get_from_extra_config(
"backends", ["UCX"] "backends", ["UCX"]
) )
# TODO temporary, once nixl allows for telemetry flag in config
# (next release), we can remove this env var.
os.environ["NIXL_TELEMETRY_ENABLE"] = "1"
# Agent. # Agent.
non_ucx_backends = [b for b in self.nixl_backends if b != "UCX"] non_ucx_backends = [b for b in self.nixl_backends if b != "UCX"]
...@@ -828,10 +824,11 @@ class NixlConnectorWorker: ...@@ -828,10 +824,11 @@ class NixlConnectorWorker:
if nixl_agent_config is None: if nixl_agent_config is None:
config = None config = None
else: else:
# Enable telemetry by default for NIXL 0.7.1 and above.
config = ( config = (
nixl_agent_config(backends=self.nixl_backends) nixl_agent_config(backends=self.nixl_backends, capture_telemetry=True)
if len(non_ucx_backends) > 0 if len(non_ucx_backends) > 0
else nixl_agent_config(num_threads=num_threads) else nixl_agent_config(num_threads=num_threads, capture_telemetry=True)
) )
self.nixl_wrapper = NixlWrapper(str(uuid.uuid4()), config) self.nixl_wrapper = NixlWrapper(str(uuid.uuid4()), config)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment