Unverified Commit 1b9b1664 authored by rongfu.leng's avatar rongfu.leng Committed by GitHub
Browse files

[Misc] update dict parse to EPLBConfig from json dumps to dict unpacking (#23305)


Signed-off-by: default avatarrongfu.leng <rongfu.leng@daocloud.io>
parent e76e2335
...@@ -6,7 +6,7 @@ from dataclasses import field ...@@ -6,7 +6,7 @@ from dataclasses import field
from typing import TYPE_CHECKING, Any, Literal, Optional, Union from typing import TYPE_CHECKING, Any, Literal, Optional, Union
import torch import torch
from pydantic import TypeAdapter, model_validator from pydantic import model_validator
from pydantic.dataclasses import dataclass from pydantic.dataclasses import dataclass
from torch.distributed import ProcessGroup, ReduceOp from torch.distributed import ProcessGroup, ReduceOp
from typing_extensions import Self from typing_extensions import Self
...@@ -56,13 +56,6 @@ class EPLBConfig: ...@@ -56,13 +56,6 @@ class EPLBConfig:
This is turned off by default since it will cause communication overhead. This is turned off by default since it will cause communication overhead.
""" """
@classmethod
def from_cli(cls, cli_value: str) -> "EPLBConfig":
"""Parse the CLI value for the compilation config.
-O1, -O2, -O3, etc. is handled in FlexibleArgumentParser.
"""
return TypeAdapter(EPLBConfig).validate_json(cli_value)
@config @config
@dataclass @dataclass
......
...@@ -455,8 +455,7 @@ class EngineArgs: ...@@ -455,8 +455,7 @@ class EngineArgs:
self.compilation_config = CompilationConfig( self.compilation_config = CompilationConfig(
**self.compilation_config) **self.compilation_config)
if isinstance(self.eplb_config, dict): if isinstance(self.eplb_config, dict):
self.eplb_config = EPLBConfig.from_cli(json.dumps( self.eplb_config = EPLBConfig(**self.eplb_config)
self.eplb_config))
# Setup plugins # Setup plugins
from vllm.plugins import load_general_plugins from vllm.plugins import load_general_plugins
load_general_plugins() load_general_plugins()
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment