Unverified Commit 17c47fb8 authored by Elvir Crnčević's avatar Elvir Crnčević Committed by GitHub
Browse files

[Bugfix] Fix EP weight filter breaking EPLB and NVFP4 accuracy (#37322)


Signed-off-by: default avatarElvir Crncevic <elvircrn@gmail.com>
Co-authored-by: default avatarClaude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: default avatarKevin H. Luu <khluu000@gmail.com>
parent b322b197
......@@ -320,6 +320,13 @@ class DefaultModelLoader(BaseModelLoader):
):
return
# When EPLB is enabled, redundant physical expert slots may map to
# logical experts that belong to other ranks in the default partition.
# The weight loader needs to see ALL logical expert weights so it can
# populate these redundant slots. Skip the filter entirely.
if parallel_config.enable_eplb:
return
num_experts = model_config.get_num_experts()
if num_experts <= 0:
return
......
......@@ -73,4 +73,9 @@ def should_skip_weight(
if eid is None:
# Not an expert weight (dense / shared-expert / embedding) → keep.
return False
# Only skip heavy weight tensors, never scale/metadata tensors.
# Scale tensors are tiny and some backends need them from ALL experts
# (e.g. FlashInfer NVFP4 computes a global max of activation scales).
if not weight_name.endswith(".weight"):
return False
return eid not in local_expert_ids
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment