Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
0b9a735e
Unverified
Commit
0b9a735e
authored
Jan 24, 2026
by
7. Sun
Committed by
GitHub
Jan 24, 2026
Browse files
[Tests] Clarify pytest skip reasons with actionable context (#32981)
Signed-off-by:
7. Sun
<
jhao.sun@gmail.com
>
parent
14d03b8d
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
3 deletions
+7
-3
tests/samplers/test_beam_search.py
tests/samplers/test_beam_search.py
+2
-2
tests/v1/sample/test_topk_topp_sampler.py
tests/v1/sample/test_topk_topp_sampler.py
+5
-1
No files found.
tests/samplers/test_beam_search.py
View file @
0b9a735e
...
...
@@ -20,7 +20,7 @@ MM_BEAM_WIDTHS = [2]
MODELS
=
[
"TinyLlama/TinyLlama-1.1B-Chat-v1.0"
]
@
pytest
.
mark
.
skip_v1
#
FIXME: This fails on V1 right now.
@
pytest
.
mark
.
skip_v1
#
V1 engine does not yet support beam search
@
pytest
.
mark
.
parametrize
(
"model"
,
MODELS
)
@
pytest
.
mark
.
parametrize
(
"dtype"
,
[
"half"
])
@
pytest
.
mark
.
parametrize
(
"max_tokens"
,
MAX_TOKENS
)
...
...
@@ -62,7 +62,7 @@ def test_beam_search_single_input(
)
@
pytest
.
mark
.
skip_v1
#
FIXME: This fails on V1 right now.
@
pytest
.
mark
.
skip_v1
#
V1 engine does not yet support beam search
@
pytest
.
mark
.
parametrize
(
"model"
,
MODELS
)
@
pytest
.
mark
.
parametrize
(
"dtype"
,
[
"half"
])
@
pytest
.
mark
.
parametrize
(
"max_tokens"
,
MAX_TOKENS
)
...
...
tests/v1/sample/test_topk_topp_sampler.py
View file @
0b9a735e
...
...
@@ -48,7 +48,11 @@ def test_topk_impl_equivalence():
assert
torch
.
allclose
(
result1
,
result2
)
@
pytest
.
mark
.
skip
(
reason
=
"FIXME: This test is failing right now."
)
@
pytest
.
mark
.
skip
(
reason
=
"FlashInfer top-k/top-p renorm comparison fails; "
"needs investigation of tolerance threshold or "
"interface differences between Python and FlashInfer implementations"
)
def
test_flashinfer_sampler
():
"""
This test verifies that the FlashInfer top-k and top-p sampling
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment