Unverified Commit 0933f9d5 authored by Nick Hill's avatar Nick Hill Committed by GitHub
Browse files

[BugFix][KVConn] Fix use of `get_required_kvcache_layout` (#22734)


Signed-off-by: default avatarNick Hill <nhill@redhat.com>
parent f1f0d2fa
......@@ -325,4 +325,8 @@ class KVConnectorBase_V1(ABC):
str: the required KV cache layout. e.g. HND, or NHD.
None if the connector does not require a specific layout.
"""
if cls is KVConnectorBase_V1:
raise TypeError("get_required_kvcache_layout should not be called "
"on the abstract base class")
return None
......@@ -228,9 +228,10 @@ class MultiConnector(KVConnectorBase_V1):
for ktc in ktcs:
kv_transfer_config = KVTransferConfig(**ktc)
temp_vllm_config.kv_transfer_config = kv_transfer_config
connector_cls = KVConnectorFactory.get_connector_class(
kv_transfer_config)
required_kvcache_layout = (
KVConnectorBase_V1.get_required_kvcache_layout(
temp_vllm_config))
connector_cls.get_required_kvcache_layout(temp_vllm_config))
if required_kvcache_layout is not None:
layouts.add(required_kvcache_layout)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment