Unverified Commit 059d4cdb authored by Nick Hill's avatar Nick Hill Committed by GitHub
Browse files

[BugFix] Fix DP headless mode arg validation (#20398)


Signed-off-by: default avatarNick Hill <nhill@redhat.com>
parent bdb84e26
...@@ -119,6 +119,10 @@ def run_headless(args: argparse.Namespace): ...@@ -119,6 +119,10 @@ def run_headless(args: argparse.Namespace):
if not envs.VLLM_USE_V1: if not envs.VLLM_USE_V1:
raise ValueError("Headless mode is only supported for V1") raise ValueError("Headless mode is only supported for V1")
if engine_args.data_parallel_rank is not None:
raise ValueError("data_parallel_rank is not applicable in "
"headless mode")
parallel_config = vllm_config.parallel_config parallel_config = vllm_config.parallel_config
local_engine_count = parallel_config.data_parallel_size_local local_engine_count = parallel_config.data_parallel_size_local
...@@ -126,10 +130,6 @@ def run_headless(args: argparse.Namespace): ...@@ -126,10 +130,6 @@ def run_headless(args: argparse.Namespace):
raise ValueError("data_parallel_size_local must be > 0 in " raise ValueError("data_parallel_size_local must be > 0 in "
"headless mode") "headless mode")
if parallel_config.data_parallel_rank is not None:
raise ValueError("data_parallel_rank is not applicable in "
"headless mode")
host = parallel_config.data_parallel_master_ip host = parallel_config.data_parallel_master_ip
port = engine_args.data_parallel_rpc_port # add to config too port = engine_args.data_parallel_rpc_port # add to config too
handshake_address = get_tcp_uri(host, port) handshake_address = get_tcp_uri(host, port)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment