Fix segfault passing null to sox_close (#174)

fddd3f2c · Edward Z. Yang · Soumith Chintala · 873af313 · fddd3f2c
Commit fddd3f2c authored Jul 29, 2019 by Edward Z. Yang Committed by Soumith Chintala Jul 29, 2019
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

torchaudio/torch_sox.cpp torchaudio/torch_sox.cpp +3 -1

No files found.
--- a/torchaudio/torch_sox.cpp
+++ b/torchaudio/torch_sox.cpp
@@ -18,8 +18,10 @@ struct SoxDescriptor {
  SoxDescriptor& operator=(const SoxDescriptor& other) = delete;
  SoxDescriptor& operator=(SoxDescriptor&& other) = delete;
  ~SoxDescriptor() {
+    if (fd_ != nullptr) {
      sox_close(fd_);
    }
+  }
  sox_format_t* operator->() noexcept {
    return fd_;
  }