Commit 5a2d114d authored by moto's avatar moto Committed by Facebook GitHub Bot
Browse files

Refactor and functionize the library definition (#2040)

Summary:
(See https://github.com/pytorch/audio/issues/2038 description for the overall goal.)

This commit turns the part that defines `libtorchaudio` into a function
so that it becomes easy to define libraries in the same way as `libtorchaudio`.

Built on top of https://github.com/pytorch/audio/issues/2039

Pull Request resolved: https://github.com/pytorch/audio/pull/2040

Reviewed By: hwangjeff

Differential Revision: D32851990

Pulled By: mthrok

fbshipit-source-id: a8206c62b076bc0849ada1a66c7502ae5ea35e28
parent 70c7e7e1
...@@ -102,35 +102,28 @@ endif() ...@@ -102,35 +102,28 @@ endif()
#------------------------------------------------------------------------------# #------------------------------------------------------------------------------#
# END OF CUSTOMIZATION LOGICS # END OF CUSTOMIZATION LOGICS
#------------------------------------------------------------------------------# #------------------------------------------------------------------------------#
add_library( function (define_library name source include_dirs link_libraries compile_defs)
libtorchaudio add_library(${name} SHARED ${source})
SHARED target_include_directories(${name} PRIVATE ${include_dirs})
${LIBTORCHAUDIO_SOURCES} target_link_libraries(${name} ${link_libraries})
target_compile_definitions(${name} PRIVATE ${compile_defs})
set_target_properties(${name} PROPERTIES PREFIX "")
if (MSVC)
set_target_properties(${name} PROPERTIES SUFFIX ".pyd")
endif(MSVC)
install(
TARGETS ${name}
LIBRARY DESTINATION lib
RUNTIME DESTINATION lib # For Windows
) )
set_target_properties(libtorchaudio PROPERTIES PREFIX "") endfunction()
target_include_directories( define_library(
libtorchaudio
PRIVATE
${LIBTORCHAUDIO_INCLUDE_DIRS}
)
target_link_libraries(
libtorchaudio
${LIBTORCHAUDIO_LINK_LIBRARIES}
)
target_compile_definitions(
libtorchaudio libtorchaudio
PRIVATE ${LIBTORCHAUDIO_COMPILE_DEFINITIONS} "${LIBTORCHAUDIO_SOURCES}"
) "${LIBTORCHAUDIO_INCLUDE_DIRS}"
"${LIBTORCHAUDIO_LINK_LIBRARIES}"
if (MSVC) "${LIBTORCHAUDIO_COMPILE_DEFINITIONS}"
set_target_properties(libtorchaudio PROPERTIES SUFFIX ".pyd")
endif(MSVC)
install(
TARGETS libtorchaudio
LIBRARY DESTINATION lib
RUNTIME DESTINATION lib # For Windows
) )
if (APPLE) if (APPLE)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment