camera refactoring

Summary: Refactor cameras * CamerasBase was enhanced with `transform_points_screen` that transforms projected points from NDC to screen space * OpenGLPerspective, OpenGLOrthographic -> FoVPerspective, FoVOrthographic * SfMPerspective, SfMOrthographic -> Perspective, Orthographic * PerspectiveCamera can optionally be constructred with screen space parameters * Note on Cameras and coordinate systems was added Reviewed By: nikhilaravi Differential Revision: D23168525 fbshipit-source-id: dd138e2b2cc7e0e0d9f34c45b8251c01266a2063

camera refactoring
Summary: Refactor cameras * CamerasBase was enhanced with `transform_points_screen` that transforms projected points from NDC to screen space * OpenGLPerspective, OpenGLOrthographic -> FoVPerspective, FoVOrthographic * SfMPerspective, SfMOrthographic -> Perspective, Orthographic * PerspectiveCamera can optionally be constructred with screen space parameters * Note on Cameras and coordinate systems was added Reviewed By: nikhilaravi Differential Revision: D23168525 fbshipit-source-id: dd138e2b2cc7e0e0d9f34c45b8251c01266a2063
57a22e73 · Georgia Gkioxari · Facebook GitHub Bot · 9242e7e6 · 57a22e73 · 57a22e73
Commit 57a22e73 authored Aug 20, 2020 by Georgia Gkioxari Committed by Facebook GitHub Bot Aug 20, 2020
20 changed files
--- a/tests/data/test_simple_sphere_dark_FoVOrthographicCameras.png
+++ b/tests/data/test_simple_sphere_dark_FoVOrthographicCameras.png
--- a/tests/data/test_simple_sphere_dark_FoVPerspectiveCameras.png
+++ b/tests/data/test_simple_sphere_dark_FoVPerspectiveCameras.png
--- a/tests/data/test_simple_sphere_dark_OrthographicCameras.png
+++ b/tests/data/test_simple_sphere_dark_OrthographicCameras.png
--- a/tests/data/test_simple_sphere_dark_PerspectiveCameras.png
+++ b/tests/data/test_simple_sphere_dark_PerspectiveCameras.png
--- a/tests/data/test_simple_sphere_dark_elevated_FoVOrthographicCameras.png
+++ b/tests/data/test_simple_sphere_dark_elevated_FoVOrthographicCameras.png
--- a/tests/data/test_simple_sphere_dark_elevated_FoVPerspectiveCameras.png
+++ b/tests/data/test_simple_sphere_dark_elevated_FoVPerspectiveCameras.png
--- a/tests/data/test_simple_sphere_dark_elevated_OrthographicCameras.png
+++ b/tests/data/test_simple_sphere_dark_elevated_OrthographicCameras.png
--- a/tests/data/test_simple_sphere_dark_elevated_PerspectiveCameras.png
+++ b/tests/data/test_simple_sphere_dark_elevated_PerspectiveCameras.png
--- a/tests/data/test_simple_sphere_dark_elevated_camera.png
+++ b/tests/data/test_simple_sphere_dark_elevated_camera.png
--- a/tests/data/test_simple_sphere_light_flat.png
+++ b/tests/data/test_simple_sphere_light_flat.png
--- a/tests/data/test_simple_sphere_light_flat_FoVOrthographicCameras.png
+++ b/tests/data/test_simple_sphere_light_flat_FoVOrthographicCameras.png
--- a/tests/data/test_simple_sphere_light_flat_FoVPerspectiveCameras.png
+++ b/tests/data/test_simple_sphere_light_flat_FoVPerspectiveCameras.png
--- a/tests/data/test_simple_sphere_light_flat_OrthographicCameras.png
+++ b/tests/data/test_simple_sphere_light_flat_OrthographicCameras.png
--- a/tests/data/test_simple_sphere_light_flat_PerspectiveCameras.png
+++ b/tests/data/test_simple_sphere_light_flat_PerspectiveCameras.png
--- a/tests/data/test_simple_sphere_light_flat_elevated_FoVOrthographicCameras.png
+++ b/tests/data/test_simple_sphere_light_flat_elevated_FoVOrthographicCameras.png
--- a/tests/data/test_simple_sphere_light_flat_elevated_FoVPerspectiveCameras.png
+++ b/tests/data/test_simple_sphere_light_flat_elevated_FoVPerspectiveCameras.png
--- a/tests/data/test_simple_sphere_light_flat_elevated_OrthographicCameras.png
+++ b/tests/data/test_simple_sphere_light_flat_elevated_OrthographicCameras.png
--- a/tests/data/test_simple_sphere_light_flat_elevated_PerspectiveCameras.png
+++ b/tests/data/test_simple_sphere_light_flat_elevated_PerspectiveCameras.png
--- a/tests/data/test_simple_sphere_light_flat_elevated_camera.png
+++ b/tests/data/test_simple_sphere_light_flat_elevated_camera.png
--- a/tests/data/test_simple_sphere_light_gouraud.png
+++ b/tests/data/test_simple_sphere_light_gouraud.png