Commit 1af6bf47 authored by Richard Barnes's avatar Richard Barnes Committed by Facebook GitHub Bot
Browse files

Replace hasattr with getattr in vision/fair/pytorch3d/pytorch3d/renderer/cameras.py

Summary:
The pattern
```
X.Y if hasattr(X, "Y") else Z
```
can be replaced with
```
getattr(X, "Y", Z)
```

The [getattr](https://www.w3schools.com/python/ref_func_getattr.asp) function gives more succinct code than the [hasattr](https://www.w3schools.com/python/ref_func_hasattr.asp) function. Please use it when appropriate.

**This diff is very low risk. Green tests indicate that you can safely Accept & Ship.**

Reviewed By: bottler

Differential Revision: D44886893

fbshipit-source-id: 86ba23e837217e1ebd64bf8e27d286257894839e
parent 355d6332
......@@ -375,14 +375,14 @@ class CamerasBase(TensorProperties):
raise NotImplementedError()
def get_znear(self):
return self.znear if hasattr(self, "znear") else None
return getattr(self, "znear", None)
def get_image_size(self):
"""
Returns the image size, if provided, expected in the form of (height, width)
The image size is used for conversion of projected points to screen coordinates.
"""
return self.image_size if hasattr(self, "image_size") else None
return getattr(self, "image_size", None)
def __getitem__(
self, index: Union[int, List[int], torch.BoolTensor, torch.LongTensor]
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment