Unverified Commit 64fde73b authored by Fengzhe Zhou's avatar Fengzhe Zhou Committed by GitHub
Browse files

[Fix] Use logger.error on failure (#960)

parent ed663ca1
...@@ -189,7 +189,7 @@ class LocalRunner(BaseRunner): ...@@ -189,7 +189,7 @@ class LocalRunner(BaseRunner):
stderr=stdout) stderr=stdout)
if result.returncode != 0: if result.returncode != 0:
logger.warning(f'task {task_name} fail, see\n{out_path}') logger.error(f'task {task_name} fail, see\n{out_path}')
finally: finally:
# Clean up # Clean up
os.remove(param_file) os.remove(param_file)
......
...@@ -128,7 +128,7 @@ def launch(task: BaseTask, tokens: SyncManager.Semaphore): ...@@ -128,7 +128,7 @@ def launch(task: BaseTask, tokens: SyncManager.Semaphore):
traceback.print_exc() traceback.print_exc()
# reset stdout and stderr # reset stdout and stderr
reset_std() reset_std()
logger.warning(f'task {task_name} fail, see\n{out_path}') logger.error(f'task {task_name} fail, see\n{out_path}')
returncode = 1 returncode = 1
else: else:
# reset stdout and stderr # reset stdout and stderr
......
...@@ -151,7 +151,7 @@ class SlurmRunner(BaseRunner): ...@@ -151,7 +151,7 @@ class SlurmRunner(BaseRunner):
stderr=stdout) stderr=stdout)
if result.returncode != 0 and not self.debug: if result.returncode != 0 and not self.debug:
logger.warning(f'task {task_name} fail, see\n{out_path}') logger.error(f'task {task_name} fail, see\n{out_path}')
finally: finally:
# Clean up # Clean up
os.remove(param_file) os.remove(param_file)
......
...@@ -242,7 +242,7 @@ class SlurmSequentialRunner(BaseRunner): ...@@ -242,7 +242,7 @@ class SlurmSequentialRunner(BaseRunner):
retry -= 1 retry -= 1
cmd = get_cmd() cmd = get_cmd()
else: else:
logger.warning( logger.error(
f'task {task_name} fail, see\n{out_path}') f'task {task_name} fail, see\n{out_path}')
break break
else: else:
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment