Skip to content

GitLab

Unverified Commit 9bc5864a authored by Michael Yang's avatar Michael Yang Committed by GitHub
Browse files

Merge pull request #918 from jmorganca/mxyng/fix-out-of-space 

fix(download): no retry when out of space
parents b88cc0fa 910816a5
Show whitespace changes
Inline Side-by-side
Showing with 3 additions and 1 deletion
server/download.go
View file @ 9bc5864a
...@@ -15,6 +15,7 @@ import ( ...@@ -15,6 +15,7 @@ import (
"strings" "strings"
"sync" "sync"
"sync/atomic" "sync/atomic"
"syscall"
"time" "time"
"golang.org/x/sync/errgroup" "golang.org/x/sync/errgroup"
...@@ -158,7 +159,8 @@ func (b *blobDownload) run(ctx context.Context, requestURL *url.URL, opts *Regis ...@@ -158,7 +159,8 @@ func (b *blobDownload) run(ctx context.Context, requestURL *url.URL, opts *Regis
w := io.NewOffsetWriter(file, part.StartsAt()) w := io.NewOffsetWriter(file, part.StartsAt())
err := b.downloadChunk(inner, requestURL, w, part, opts) err := b.downloadChunk(inner, requestURL, w, part, opts)
switch { switch {
case errors.Is(err, context.Canceled): case errors.Is(err, context.Canceled), errors.Is(err, syscall.ENOSPC):
// return immediately if the context is canceled or the device is out of space
return err return err
case err != nil: case err != nil:
log.Printf("%s part %d attempt %d failed: %v, retrying", b.Digest[7:19], i, try, err) log.Printf("%s part %d attempt %d failed: %v, retrying", b.Digest[7:19], i, try, err)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment