Skip to content

GitLab

Unverified Commit 4129af92 authored by Michael Yang's avatar Michael Yang Committed by GitHub
Browse files

chore: cleanup comments + unused vars (#11225)

parent 45f216a9
Show whitespace changes
Inline Side-by-side
Showing with 0 additions and 4 deletions
convert/convert_gemma3n.go
View file @ 4129af92
...@@ -24,7 +24,6 @@ type gemma3nModel struct { ...@@ -24,7 +24,6 @@ type gemma3nModel struct {
HiddenSize uint32 `json:"hidden_size"` HiddenSize uint32 `json:"hidden_size"`
HiddenSizePerLayerInput uint32 `json:"hidden_size_per_layer_input"` HiddenSizePerLayerInput uint32 `json:"hidden_size_per_layer_input"`
IntermediateSize uint32 `json:"intermediate_size"` IntermediateSize uint32 `json:"intermediate_size"`
LaurelRank uint32 `json:"laurel_rank"`
MaxPositionEmbeddings uint32 `json:"max_position_embeddings"` MaxPositionEmbeddings uint32 `json:"max_position_embeddings"`
NumAttentionHeads uint32 `json:"num_attention_heads"` NumAttentionHeads uint32 `json:"num_attention_heads"`
NumHiddenLayers uint32 `json:"num_hidden_layers"` NumHiddenLayers uint32 `json:"num_hidden_layers"`
...@@ -72,8 +71,6 @@ func (m *gemma3nModel) KV(t *Tokenizer) ggml.KV { ...@@ -72,8 +71,6 @@ func (m *gemma3nModel) KV(t *Tokenizer) ggml.KV {
kv["gemma3n.embedding_length"] = m.TextModel.HiddenSize kv["gemma3n.embedding_length"] = m.TextModel.HiddenSize
kv["gemma3n.feed_forward_length"] = m.TextModel.IntermediateSize kv["gemma3n.feed_forward_length"] = m.TextModel.IntermediateSize
kv["gemma3n.head_dim"] = m.TextModel.HeadDim kv["gemma3n.head_dim"] = m.TextModel.HeadDim
kv["gemma3n.laurel_rank"] = m.TextModel.LaurelRank
kv["gemma3n.num_kv_shared_layers"] = m.TextModel.NumKVSharedLayers
kv["gemma3n.rope.freq_base_local"] = m.TextModel.RopeLocalBaseFreq kv["gemma3n.rope.freq_base_local"] = m.TextModel.RopeLocalBaseFreq
kv["gemma3n.rope.freq_base"] = m.TextModel.RopeTheta kv["gemma3n.rope.freq_base"] = m.TextModel.RopeTheta
return kv return kv
......
model/models/gemma3n/model.go
View file @ 4129af92
...@@ -39,7 +39,6 @@ func New(c fs.Config) (model.Model, error) { ...@@ -39,7 +39,6 @@ func New(c fs.Config) (model.Model, error) {
), ),
} }
// TODO: setup hybrid (local sliding window + global) cache
m.Cache = kvcache.NewWrapperCache( m.Cache = kvcache.NewWrapperCache(
kvcache.NewCausalCache(m.Shift), kvcache.NewCausalCache(m.Shift),
kvcache.NewSWACache(int32(c.Uint("attention.sliding_window")), m.Shift), kvcache.NewSWACache(int32(c.Uint("attention.sliding_window")), m.Shift),
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment