Unverified Commit de1ae178 authored by Lijiao's avatar Lijiao Committed by GitHub
Browse files

fix some bugs in v1.4 bug bash (#2066)

parent b7045b19
...@@ -172,7 +172,7 @@ class NavCon extends React.Component<NavProps, NavState> { ...@@ -172,7 +172,7 @@ class NavCon extends React.Component<NavProps, NavState> {
/> />
<CommandBarButton <CommandBarButton
iconProps={infoIconAbout} iconProps={infoIconAbout}
text="about" text="About"
menuProps={aboutProps} menuProps={aboutProps}
/> />
</Stack> </Stack>
......
...@@ -56,7 +56,7 @@ class TrialsDetail extends React.Component<TrialsDetailProps, TrialDetailState> ...@@ -56,7 +56,7 @@ class TrialsDetail extends React.Component<TrialsDetailProps, TrialDetailState>
return; return;
} }
switch (this.state.searchType) { switch (this.state.searchType) {
case 'id': case 'Id':
filter = (trial): boolean => trial.info.id.toUpperCase().includes(targetValue.toUpperCase()); filter = (trial): boolean => trial.info.id.toUpperCase().includes(targetValue.toUpperCase());
break; break;
case 'Trial No.': case 'Trial No.':
...@@ -65,7 +65,7 @@ class TrialsDetail extends React.Component<TrialsDetailProps, TrialDetailState> ...@@ -65,7 +65,7 @@ class TrialsDetail extends React.Component<TrialsDetailProps, TrialDetailState>
case 'Status': case 'Status':
filter = (trial): boolean => trial.info.status.toUpperCase().includes(targetValue.toUpperCase()); filter = (trial): boolean => trial.info.status.toUpperCase().includes(targetValue.toUpperCase());
break; break;
case 'parameters': case 'Parameters':
// TODO: support filters like `x: 2` (instead of `"x": 2`) // TODO: support filters like `x: 2` (instead of `"x": 2`)
filter = (trial): boolean => JSON.stringify(trial.info.hyperParameters, null, 4).includes(targetValue); filter = (trial): boolean => JSON.stringify(trial.info.hyperParameters, null, 4).includes(targetValue);
break; break;
......
...@@ -128,7 +128,7 @@ class TableList extends React.Component<TableListProps, TableListState> { ...@@ -128,7 +128,7 @@ class TableList extends React.Component<TableListProps, TableListState> {
name: 'Default metric', name: 'Default metric',
className: 'leftTitle', className: 'leftTitle',
key: 'accuracy', key: 'accuracy',
fieldName: 'accuracy', fieldName: 'latestAccuracy',
minWidth: 200, minWidth: 200,
maxWidth: 300, maxWidth: 300,
isResizable: true, isResizable: true,
...@@ -534,8 +534,8 @@ class TableList extends React.Component<TableListProps, TableListState> { ...@@ -534,8 +534,8 @@ class TableList extends React.Component<TableListProps, TableListState> {
} }
UNSAFE_componentWillReceiveProps(nextProps: TableListProps): void { UNSAFE_componentWillReceiveProps(nextProps: TableListProps): void {
const { columnList } = nextProps; const { columnList, tableSource } = nextProps;
this.setState({ tableColumns: this.initTableColumnList(columnList) }); this.setState({ tableSourceForSort: tableSource, tableColumns: this.initTableColumnList(columnList) });
} }
render(): React.ReactNode { render(): React.ReactNode {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment