Unverified Commit d5e6af27 authored by Lijiaoa's avatar Lijiaoa Committed by GitHub
Browse files

support show NaN in detail table (#2183)



* support final result is NaN in webui

* delete unuseful change

* show NaN rather than NaN(latest)
Co-authored-by: default avatarLijiao <15910218274@163.com>
parent d1d1e915
...@@ -77,8 +77,10 @@ const getFinal = (final?: MetricDataRecord[]): FinalType | undefined => { ...@@ -77,8 +77,10 @@ const getFinal = (final?: MetricDataRecord[]): FinalType | undefined => {
if (final) { if (final) {
showDefault = parseMetrics(final[final.length - 1].data); showDefault = parseMetrics(final[final.length - 1].data);
if (typeof showDefault === 'number') { if (typeof showDefault === 'number') {
if(!isNaN(showDefault)){
showDefault = { default: showDefault }; showDefault = { default: showDefault };
return showDefault; return showDefault;
}
} else if (isArrayType(showDefault)) { } else if (isArrayType(showDefault)) {
// not support final type // not support final type
return undefined; return undefined;
......
...@@ -211,15 +211,23 @@ class Trial implements TableObj { ...@@ -211,15 +211,23 @@ class Trial implements TableObj {
public formatLatestAccuracy(): string { // TODO: this should be private public formatLatestAccuracy(): string { // TODO: this should be private
if (this.accuracy !== undefined) { if (this.accuracy !== undefined) {
if (isNaN(this.accuracy)) {
return this.accuracy.toString();
} else {
return `${formatAccuracy(this.accuracy)} (FINAL)`; return `${formatAccuracy(this.accuracy)} (FINAL)`;
}
} else if (this.intermediates.length === 0) { } else if (this.intermediates.length === 0) {
return '--'; return '--';
} else { } else {
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
const latest = this.intermediates[this.intermediates.length - 1]!; const latest = this.intermediates[this.intermediates.length - 1]!;
if (isNaN(metricAccuracy(latest))) {
return 'NaN';
} else {
return `${formatAccuracy(metricAccuracy(latest))} (LATEST)`; return `${formatAccuracy(metricAccuracy(latest))} (LATEST)`;
} }
} }
}
} }
export { Trial }; export { Trial };
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment