Fix bug when expanding rows not on the first page (#3006)

bcddacba · Yuge Zhang · GitHub · 5eec7ea5 · bcddacba
Unverified Commit bcddacba authored Oct 21, 2020 by Yuge Zhang Committed by GitHub Oct 21, 2020
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 3 deletions

src/webui/src/components/trial-detail/TableList.tsx src/webui/src/components/trial-detail/TableList.tsx +4 -3

No files found.
--- a/src/webui/src/components/trial-detail/TableList.tsx
+++ b/src/webui/src/components/trial-detail/TableList.tsx
@@ -249,7 +249,7 @@ class TableList extends React.Component<TableListProps, TableListState> {
            {
                key: '_expand',
                name: '',
-                onRender: (item, index): any => {
+                onRender: (item): any => {
                    return (
                        <Icon
                            aria-hidden={true}
@@ -269,8 +269,9 @@ class TableList extends React.Component<TableListProps, TableListState> {
                                } else {
                                    this._expandedTrialIds.delete(newItem.id);
                                }
-                                const newItems = [...this.state.displayedItems];
+                                const newItems = this.state.displayedItems.map(item =>
-                                newItems[index as number] = newItem;
+                                    item.id === newItem.id ? newItem : item
+                                );
                                this.setState({
                                    displayedItems: newItems
                                });