Unverified Commit 8f002c8b authored by SparkSnail's avatar SparkSnail Committed by GitHub
Browse files

Set version check as warning (#3654)

parent 03ff3741
...@@ -151,14 +151,13 @@ def check_version(args): ...@@ -151,14 +151,13 @@ def check_version(args):
nni_log(LogType.Info, 'nni_manager_version is {0}'.format(nni_manager_version)) nni_log(LogType.Info, 'nni_manager_version is {0}'.format(nni_manager_version))
log_entry = {} log_entry = {}
if trial_keeper_version != nni_manager_version: if trial_keeper_version != nni_manager_version:
nni_log(LogType.Error, 'Version does not match!') nni_log(LogType.Warning, 'Version does not match!')
error_message = 'NNIManager version is {0}, TrialKeeper version is {1}, NNI version does not match!'.format( error_message = 'NNIManager version is {0}, TrialKeeper version is {1}, NNI version does not match!'.format(
nni_manager_version, trial_keeper_version) nni_manager_version, trial_keeper_version)
log_entry['tag'] = 'VCFail' log_entry['tag'] = 'VCFail'
log_entry['msg'] = error_message log_entry['msg'] = error_message
rest_post(gen_send_version_url(args.nnimanager_ip, args.nnimanager_port), json.dumps(log_entry), 10, rest_post(gen_send_version_url(args.nnimanager_ip, args.nnimanager_port), json.dumps(log_entry), 10,
False) False)
os._exit(1)
else: else:
nni_log(LogType.Info, 'Version match!') nni_log(LogType.Info, 'Version match!')
log_entry['tag'] = 'VCSuccess' log_entry['tag'] = 'VCSuccess'
......
...@@ -119,7 +119,7 @@ def check_version(args): ...@@ -119,7 +119,7 @@ def check_version(args):
nni_log(LogType.Info, '{0}: nni_manager_version is {1}'.format(args.node_id, nni_manager_version)) nni_log(LogType.Info, '{0}: nni_manager_version is {1}'.format(args.node_id, nni_manager_version))
log_entry = {} log_entry = {}
if trial_runner_version != nni_manager_version: if trial_runner_version != nni_manager_version:
nni_log(LogType.Error, '{0}: Version does not match!'.format(args.node_id)) nni_log(LogType.Warning, '{0}: Version does not match!'.format(args.node_id))
error_message = '{0}: NNIManager version is {1}, Trial runner version is {2}, NNI version does not match!'.format( error_message = '{0}: NNIManager version is {1}, Trial runner version is {2}, NNI version does not match!'.format(
args.node_id, nni_manager_version, trial_runner_version) args.node_id, nni_manager_version, trial_runner_version)
log_entry['tag'] = 'VCFail' log_entry['tag'] = 'VCFail'
...@@ -127,7 +127,6 @@ def check_version(args): ...@@ -127,7 +127,6 @@ def check_version(args):
command_channel.send(CommandType.VersionCheck, log_entry) command_channel.send(CommandType.VersionCheck, log_entry)
while not command_channel.sent(): while not command_channel.sent():
time.sleep(1) time.sleep(1)
os._exit(1)
else: else:
nni_log(LogType.Info, '{0}: Version match!'.format(args.node_id)) nni_log(LogType.Info, '{0}: Version match!'.format(args.node_id))
log_entry['tag'] = 'VCSuccess' log_entry['tag'] = 'VCSuccess'
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment