Refactor NNI Manager UT (Stage 1) - setup toolchain (#4109)

ts/nni_manager/training_service/pai/paiConfig.ts

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-'use strict';
-
-import { TrialJobApplicationForm, TrialJobDetail, TrialJobStatus } from '../../common/trainingService';
+import { TrialJobApplicationForm, TrialJobDetail, TrialJobStatus } from 'common/trainingService';
 import {TrialConfig} from '../common/trialConfig';
 
 export class PAIClusterConfig {

ts/nni_manager/training_service/pai/paiJobInfoCollector.ts

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-'use strict';
-
-import * as request from 'request';
+import request from 'request';
 import { Deferred } from 'ts-deferred';
-import { NNIError, NNIErrorNames } from '../../common/errors';
-import { getLogger, Logger } from '../../common/log';
-import { TrialJobStatus } from '../../common/trainingService';
-import { ExperimentConfig, OpenpaiConfig } from '../../common/experimentConfig';
+import { NNIError, NNIErrorNames } from 'common/errors';
+import { getLogger, Logger } from 'common/log';
+import { TrialJobStatus } from 'common/trainingService';
+import { ExperimentConfig, OpenpaiConfig } from 'common/experimentConfig';
 import { PAITrialJobDetail } from './paiConfig';
 
 interface FlattenOpenpaiConfig extends ExperimentConfig, OpenpaiConfig { }
@@ -44,7 +42,7 @@ export class PAIJobInfoCollector {
         await Promise.all(updatePaiTrialJobs);
     }
 
-    private getSinglePAITrialJobInfo(protocol: string, paiTrialJob: PAITrialJobDetail, paiToken: string, config: FlattenOpenpaiConfig): Promise<void> {
+    private getSinglePAITrialJobInfo(_protocol: string, paiTrialJob: PAITrialJobDetail, paiToken: string, config: FlattenOpenpaiConfig): Promise<void> {
         const deferred: Deferred<void> = new Deferred<void>();
         if (!this.statusesNeedToCheck.includes(paiTrialJob.status)) {
             deferred.resolve();

ts/nni_manager/training_service/pai/paiJobRestServer.ts

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-'use strict';
-
 import { Request, Response, Router } from 'express';
 import { ClusterJobRestServer } from '../common/clusterJobRestServer';
 import { PAITrainingService } from './paiTrainingService';
@@ -56,7 +54,7 @@ export class PAIJobRestServer extends ClusterJobRestServer {
             }
         });
 
-        router.get(`/parameter-file-meta`, (req: Request, res: Response) => {
+        router.get(`/parameter-file-meta`, (_req: Request, res: Response) => {
             try {
                 this.log.info(`GET /parameter-file-meta`);
                 res.send(this.parameterFileMetaList);

ts/nni_manager/training_service/pai/paiTrainingService.ts

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-'use strict';
-
-import * as fs from 'fs';
-import * as path from 'path';
-import * as request from 'request';
-import * as component from '../../common/component';
+import fs from 'fs';
+import path from 'path';
+import request from 'request';
+import * as component from 'common/component';
 
 import { EventEmitter } from 'events';
 import { Deferred } from 'ts-deferred';
-import { getExperimentId } from '../../common/experimentStartupInfo';
-import { getLogger, Logger } from '../../common/log';
-import { MethodNotImplementedError } from '../../common/errors';
+import { getExperimentId } from 'common/experimentStartupInfo';
+import { getLogger, Logger } from 'common/log';
+import { MethodNotImplementedError } from 'common/errors';
 import {
     HyperParameters, NNIManagerIpConfig, TrainingService,
     TrialJobApplicationForm, TrialJobDetail, TrialJobMetric
-} from '../../common/trainingService';
-import { delay } from '../../common/utils';
-import { ExperimentConfig, OpenpaiConfig, flattenConfig, toMegaBytes } from '../../common/experimentConfig';
+} from 'common/trainingService';
+import { delay } from 'common/utils';
+import { ExperimentConfig, OpenpaiConfig, flattenConfig, toMegaBytes } from 'common/experimentConfig';
 import { PAIJobInfoCollector } from './paiJobInfoCollector';
 import { PAIJobRestServer } from './paiJobRestServer';
 import { PAITrialJobDetail, PAI_TRIAL_COMMAND_FORMAT } from './paiConfig';
 import { String } from 'typescript-string-operations';
-import { generateParamFileName, getIPV4Address, uniqueString } from '../../common/utils';
+import { generateParamFileName, getIPV4Address, uniqueString } from 'common/utils';
 import { CONTAINER_INSTALL_NNI_SHELL_FORMAT } from '../common/containerJobData';
 import { execMkdir, validateCodeDir, execCopydir } from '../common/util';
 

ts/nni_manager/training_service/remote_machine/extends/linuxCommands.ts

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-'use strict';
-
 import { OsCommands } from "../osCommands";
 import { RemoteCommandResult } from "../remoteMachineData";
 

ts/nni_manager/training_service/remote_machine/extends/windowsCommands.ts

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-'use strict';
-
 import { OsCommands } from "../osCommands";
 import { RemoteCommandResult } from "../remoteMachineData";
 

ts/nni_manager/training_service/remote_machine/gpuScheduler.ts

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-'use strict';
-
-import * as assert from 'assert';
-import { getLogger, Logger } from '../../common/log';
-import { randomSelect } from '../../common/utils';
-import { RemoteMachineConfig } from '../../common/experimentConfig';
+import assert from 'assert';
+import { getLogger, Logger } from 'common/log';
+import { randomSelect } from 'common/utils';
+import { RemoteMachineConfig } from 'common/experimentConfig';
 import { GPUInfo, ScheduleResultType } from '../common/gpuData';
 import { ExecutorManager, RemoteMachineMeta, RemoteMachineScheduleResult, RemoteMachineTrialJobDetail } from './remoteMachineData';
 
@@ -123,6 +121,7 @@ export class GPUScheduler {
                 assert(false, 'gpuInfos is undefined');
             }
         }
+        return undefined;
     }
 
     /**

ts/nni_manager/training_service/remote_machine/osCommands.ts

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-'use strict';
-
 import { RemoteCommandResult } from "./remoteMachineData";
 
 abstract class OsCommands {

ts/nni_manager/training_service/remote_machine/remoteMachineData.ts

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-'use strict';
-
-import { TrialJobApplicationForm, TrialJobDetail, TrialJobStatus } from '../../common/trainingService';
-import { RemoteMachineConfig } from '../../common/experimentConfig';
+import { TrialJobApplicationForm, TrialJobDetail, TrialJobStatus } from 'common/trainingService';
+import { RemoteMachineConfig } from 'common/experimentConfig';
 import { GPUInfo, GPUSummary, ScheduleResultType } from '../common/gpuData';
 import { ShellExecutor } from './shellExecutor';
 

ts/nni_manager/training_service/remote_machine/remoteMachineJobRestServer.ts

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-'use strict';
-
 import { ClusterJobRestServer } from '../common/clusterJobRestServer';
 import { RemoteMachineTrainingService } from './remoteMachineTrainingService';
 

ts/nni_manager/training_service/remote_machine/remoteMachineTrainingService.ts

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-'use strict';
-
-import * as assert from 'assert';
+import assert from 'assert';
 import { EventEmitter } from 'events';
-import * as fs from 'fs';
-import * as path from 'path';
+import fs from 'fs';
+import path from 'path';
 import { ShellExecutor } from 'training_service/remote_machine/shellExecutor';
 import { Deferred } from 'ts-deferred';
-import * as component from '../../common/component';
-import { NNIError, NNIErrorNames, MethodNotImplementedError } from '../../common/errors';
-import { getExperimentId } from '../../common/experimentStartupInfo';
-import { getLogger, Logger } from '../../common/log';
-import { ObservableTimer } from '../../common/observableTimer';
+import * as component from 'common/component';
+import { NNIError, NNIErrorNames, MethodNotImplementedError } from 'common/errors';
+import { getExperimentId } from 'common/experimentStartupInfo';
+import { getLogger, Logger } from 'common/log';
+import { ObservableTimer } from 'common/observableTimer';
 import {
     HyperParameters, TrainingService, TrialJobApplicationForm,
     TrialJobDetail, TrialJobMetric
-} from '../../common/trainingService';
+} from 'common/trainingService';
 import {
     delay, generateParamFileName, getExperimentRootDir, getIPV4Address, getJobCancelStatus,
     getVersion, uniqueString
-} from '../../common/utils';
-import { ExperimentConfig, RemoteConfig, RemoteMachineConfig, flattenConfig } from '../../common/experimentConfig';
+} from 'common/utils';
+import { ExperimentConfig, RemoteConfig, RemoteMachineConfig, flattenConfig } from 'common/experimentConfig';
 import { CONTAINER_INSTALL_NNI_SHELL_FORMAT } from '../common/containerJobData';
 import { GPUSummary, ScheduleResultType } from '../common/gpuData';
 import { execMkdir, validateCodeDir } from '../common/util';

ts/nni_manager/training_service/remote_machine/shellExecutor.ts

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-'use strict';
-
-import * as assert from 'assert';
-import * as fs from 'fs';
-import * as os from 'os';
-import * as path from 'path';
+import assert from 'assert';
+import fs from 'fs';
+import os from 'os';
+import path from 'path';
 import { Client, ClientChannel, ConnectConfig, SFTPWrapper } from 'ssh2';
-import * as stream from 'stream';
+import stream from 'stream';
 import { Deferred } from "ts-deferred";
-import { getLogger, Logger } from '../../common/log';
-import { uniqueString, randomInt } from '../../common/utils';
+import { getLogger, Logger } from 'common/log';
+import { uniqueString, randomInt } from 'common/utils';
 import { execRemove, tarAdd } from '../common/util';
 import { LinuxCommands } from "./extends/linuxCommands";
 import { WindowsCommands } from './extends/windowsCommands';
 import { OsCommands } from "./osCommands";
 import { RemoteCommandResult, RemoteMachineMeta } from "./remoteMachineData";
-import { NNIError, NNIErrorNames } from '../../common/errors';
+import { NNIError, NNIErrorNames } from 'common/errors';
 
 class ShellExecutor {
     public name: string = "";

ts/nni_manager/training_service/reusable/aml/amlClient.ts

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-'use strict';
-
 import { Deferred } from 'ts-deferred';
 import { PythonShell } from 'python-shell';
 

ts/nni_manager/training_service/reusable/aml/amlConfig.ts

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-'use strict';
-
-import { TrialConfig } from '../../common/trialConfig';
+import { TrialConfig } from 'training_service/common/trialConfig';
 import { EnvironmentInformation } from '../environment';
 import { AMLClient } from '../aml/amlClient';
 

ts/nni_manager/training_service/reusable/channels/amlCommandChannel.ts

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-'use strict';
-
-import { delay } from "../../../common/utils";
+import { delay } from "common/utils";
 import { AMLEnvironmentInformation } from '../aml/amlConfig';
 import { CommandChannel, RunnerConnection } from "../commandChannel";
 import { Channel, EnvironmentInformation } from "../environment";

ts/nni_manager/training_service/reusable/channels/fileCommandChannel.ts

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-'use strict';
-
-import * as component from "../../../common/component";
-import { delay } from "../../../common/utils";
+import * as component from "common/component";
+import { delay } from "common/utils";
 import { CommandChannel, RunnerConnection } from "../commandChannel";
 import { Channel, EnvironmentInformation } from "../environment";
 import { StorageService } from "../storageService";

ts/nni_manager/training_service/reusable/channels/webCommandChannel.ts

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-'use strict';
-
 import { Server as SocketServer } from "ws";
-import { getBasePort, getExperimentId } from "../../../common/experimentStartupInfo";
-import { INITIALIZED } from '../../../core/commands';
+import { getBasePort, getExperimentId } from "common/experimentStartupInfo";
+import { INITIALIZED } from 'core/commands';
 import { CommandChannel, RunnerConnection } from "../commandChannel";
 import { Channel, EnvironmentInformation } from "../environment";
 import { EventEmitter } from "events";

ts/nni_manager/training_service/reusable/commandChannel.ts

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-'use strict';
-
 import { EventEmitter } from "events";
-import { getLogger, Logger } from "../../common/log";
-import { TRIAL_COMMANDS } from "../../core/commands";
-import { encodeCommand } from "../../core/ipcInterface";
+import { getLogger, Logger } from "common/log";
+import { TRIAL_COMMANDS } from "core/commands";
+import { encodeCommand } from "core/ipcInterface";
 import { Channel, EnvironmentInformation } from "./environment";
 
 const acceptedCommands: Set<string> = new Set<string>(TRIAL_COMMANDS);

ts/nni_manager/training_service/reusable/dlc/dlcClient.ts

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-'use strict';
-
 import { Deferred } from 'ts-deferred';
 import { PythonShell } from 'python-shell';
-import { getLogger, Logger } from '../../../common/log';
+import { getLogger, Logger } from 'common/log';
 
 export class DlcClient {
     private log: Logger;

ts/nni_manager/training_service/reusable/dlc/dlcConfig.ts

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-'use strict';
-
-import { TrialConfig } from '../../common/trialConfig';
+import { TrialConfig } from 'training_service/common/trialConfig';
 import { EnvironmentInformation } from '../environment';
 import { DlcClient } from '../dlc/dlcClient';