Unverified Commit 227a4619 authored by chicm-ms's avatar chicm-ms Committed by GitHub
Browse files

Update NNIManager.getTrialJob to contain all hyper parameters (#1288)

* Update NNIManager.getTrialJob
parent 797f0e2c
...@@ -141,6 +141,7 @@ class NNIDataStore implements DataStore { ...@@ -141,6 +141,7 @@ class NNIDataStore implements DataStore {
public async getTrialJob(trialJobId: string): Promise<TrialJobInfo> { public async getTrialJob(trialJobId: string): Promise<TrialJobInfo> {
const trialJobs: TrialJobInfo[] = await this.queryTrialJobs(undefined, trialJobId); const trialJobs: TrialJobInfo[] = await this.queryTrialJobs(undefined, trialJobId);
assert(trialJobs.length <= 1);
return trialJobs[0]; return trialJobs[0];
} }
......
...@@ -242,10 +242,8 @@ class NNIManager implements Manager { ...@@ -242,10 +242,8 @@ class NNIManager implements Manager {
}); });
} }
public getTrialJob(trialJobId: string): Promise<TrialJobDetail> { public getTrialJob(trialJobId: string): Promise<TrialJobInfo> {
return Promise.resolve( return this.dataStore.getTrialJob(trialJobId);
this.trainingService.getTrialJob(trialJobId)
);
} }
public async setClusterMetadata(key: string, value: string): Promise<void> { public async setClusterMetadata(key: string, value: string): Promise<void> {
......
...@@ -221,7 +221,12 @@ class MockedDataStore implements DataStore { ...@@ -221,7 +221,12 @@ class MockedDataStore implements DataStore {
} }
public getTrialJob(trialJobId: string): Promise<TrialJobInfo> { public getTrialJob(trialJobId: string): Promise<TrialJobInfo> {
throw new Error("Method not implemented."); return Promise.resolve({
id: '1234',
status: 'SUCCEEDED',
startTime: Date.now(),
endTime: Date.now()
});
} }
private async getFinalMetricData(trialJobId: string): Promise<any> { private async getFinalMetricData(trialJobId: string): Promise<any> {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment