Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
OpenDAS
mmdetection3d
Commits
b035bc8e
Unverified
Commit
b035bc8e
authored
Apr 18, 2021
by
Yezhen Cong
Committed by
GitHub
Apr 18, 2021
Browse files
Temporarily fix docstring of three coordinate systems to reduce confusion. (#457)
parent
237cebff
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
18 additions
and
7 deletions
+18
-7
mmdet3d/core/bbox/structures/cam_box3d.py
mmdet3d/core/bbox/structures/cam_box3d.py
+5
-2
mmdet3d/core/bbox/structures/depth_box3d.py
mmdet3d/core/bbox/structures/depth_box3d.py
+7
-2
mmdet3d/core/bbox/structures/lidar_box3d.py
mmdet3d/core/bbox/structures/lidar_box3d.py
+6
-3
No files found.
mmdet3d/core/bbox/structures/cam_box3d.py
View file @
b035bc8e
...
@@ -13,7 +13,7 @@ class CameraInstance3DBoxes(BaseInstance3DBoxes):
...
@@ -13,7 +13,7 @@ class CameraInstance3DBoxes(BaseInstance3DBoxes):
.. code-block:: none
.. code-block:: none
z front (yaw=0.5*pi)
z front (yaw=
-
0.5*pi)
/
/
/
/
0 ------> x right (yaw=0)
0 ------> x right (yaw=0)
...
@@ -24,9 +24,12 @@ class CameraInstance3DBoxes(BaseInstance3DBoxes):
...
@@ -24,9 +24,12 @@ class CameraInstance3DBoxes(BaseInstance3DBoxes):
The relative coordinate of bottom center in a CAM box is (0.5, 1.0, 0.5),
The relative coordinate of bottom center in a CAM box is (0.5, 1.0, 0.5),
and the yaw is around the y axis, thus the rotation axis=1.
and the yaw is around the y axis, thus the rotation axis=1.
The yaw is 0 at the positive direction of x axis, and
in
creases from
The yaw is 0 at the positive direction of x axis, and
de
creases from
the positive direction of x to the positive direction of z.
the positive direction of x to the positive direction of z.
A refactor is ongoing to make the three coordinate systems
easier to understand and convert between each other.
Attributes:
Attributes:
tensor (torch.Tensor): Float matrix of N x box_dim.
tensor (torch.Tensor): Float matrix of N x box_dim.
box_dim (int): Integer indicates the dimension of a box
box_dim (int): Integer indicates the dimension of a box
...
...
mmdet3d/core/bbox/structures/depth_box3d.py
View file @
b035bc8e
...
@@ -14,7 +14,7 @@ class DepthInstance3DBoxes(BaseInstance3DBoxes):
...
@@ -14,7 +14,7 @@ class DepthInstance3DBoxes(BaseInstance3DBoxes):
.. code-block:: none
.. code-block:: none
up z y front (yaw=0.5*pi)
up z y front (yaw=
-
0.5*pi)
^ ^
^ ^
| /
| /
| /
| /
...
@@ -22,8 +22,13 @@ class DepthInstance3DBoxes(BaseInstance3DBoxes):
...
@@ -22,8 +22,13 @@ class DepthInstance3DBoxes(BaseInstance3DBoxes):
The relative coordinate of bottom center in a Depth box is (0.5, 0.5, 0),
The relative coordinate of bottom center in a Depth box is (0.5, 0.5, 0),
and the yaw is around the z axis, thus the rotation axis=2.
and the yaw is around the z axis, thus the rotation axis=2.
The yaw is 0 at the positive direction of x axis, and
in
creases from
The yaw is 0 at the positive direction of x axis, and
de
creases from
the positive direction of x to the positive direction of y.
the positive direction of x to the positive direction of y.
Also note that rotation of DepthInstance3DBoxes is counterclockwise,
which is reverse to the definition of the yaw angle (clockwise).
A refactor is ongoing to make the three coordinate systems
easier to understand and convert between each other.
Attributes:
Attributes:
tensor (torch.Tensor): Float matrix of N x box_dim.
tensor (torch.Tensor): Float matrix of N x box_dim.
...
...
mmdet3d/core/bbox/structures/lidar_box3d.py
View file @
b035bc8e
...
@@ -14,17 +14,20 @@ class LiDARInstance3DBoxes(BaseInstance3DBoxes):
...
@@ -14,17 +14,20 @@ class LiDARInstance3DBoxes(BaseInstance3DBoxes):
.. code-block:: none
.. code-block:: none
up z x front (yaw=0.5*pi)
up z x front (yaw=
-
0.5*pi)
^ ^
^ ^
| /
| /
| /
| /
(yaw=pi) left y <------ 0
(yaw=
-
pi) left y <------ 0
-------- (yaw=0)
The relative coordinate of bottom center in a LiDAR box is (0.5, 0.5, 0),
The relative coordinate of bottom center in a LiDAR box is (0.5, 0.5, 0),
and the yaw is around the z axis, thus the rotation axis=2.
and the yaw is around the z axis, thus the rotation axis=2.
The yaw is 0 at the negative direction of y axis, and
in
creases from
The yaw is 0 at the negative direction of y axis, and
de
creases from
the negative direction of y to the positive direction of x.
the negative direction of y to the positive direction of x.
A refactor is ongoing to make the three coordinate systems
easier to understand and convert between each other.
Attributes:
Attributes:
tensor (torch.Tensor): Float matrix of N x box_dim.
tensor (torch.Tensor): Float matrix of N x box_dim.
box_dim (int): Integer indicating the dimension of a box.
box_dim (int): Integer indicating the dimension of a box.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment