Commit cd3529b9 authored by Evelina Bakhturina's avatar Evelina Bakhturina
Browse files

review feedback

parent 71f9e76c
...@@ -13,8 +13,6 @@ ...@@ -13,8 +13,6 @@
# See the License for the specific language governing permissions and # See the License for the specific language governing permissions and
# limitations under the License. # limitations under the License.
import os
from .package_info import ( from .package_info import (
__contact_emails__, __contact_emails__,
__contact_names__, __contact_names__,
...@@ -27,12 +25,11 @@ from .package_info import ( ...@@ -27,12 +25,11 @@ from .package_info import (
__version__, __version__,
) )
if "MEGATRON_PACKAGE_BUILDING" not in os.environ: from .global_vars import get_args
from .global_vars import get_args from .global_vars import get_tokenizer
from .global_vars import get_tokenizer from .global_vars import get_tensorboard_writer
from .global_vars import get_tensorboard_writer from .global_vars import get_adlr_autoresume
from .global_vars import get_adlr_autoresume from .global_vars import get_timers
from .global_vars import get_timers
import torch import torch
......
...@@ -16,8 +16,8 @@ ...@@ -16,8 +16,8 @@
# limitations under the License. # limitations under the License.
MAJOR = 0 MAJOR = 0
MINOR = 0 MINOR = 1
PATCH = 1 PATCH = 0
# Use the following formatting: (major, minor, patch) # Use the following formatting: (major, minor, patch)
VERSION = (MAJOR, MINOR, PATCH) VERSION = (MAJOR, MINOR, PATCH)
......
...@@ -18,17 +18,10 @@ ...@@ -18,17 +18,10 @@
"""Setup for pip package.""" """Setup for pip package."""
import codecs
import os import os
import subprocess
import sys import sys
from distutils import cmd as distutils_cmd
from distutils import log as distutils_log
from itertools import chain
import setuptools import setuptools
import sys
if sys.version_info < (3,): if sys.version_info < (3,):
raise Exception("Python 2 is not supported by Megatron.") raise Exception("Python 2 is not supported by Megatron.")
...@@ -44,9 +37,6 @@ def is_build_action(): ...@@ -44,9 +37,6 @@ def is_build_action():
return False return False
if is_build_action():
os.environ['MEGATRON_PACKAGE_BUILDING'] = 'True'
from megatron.package_info import ( from megatron.package_info import (
__contact_emails__, __contact_emails__,
__contact_names__, __contact_names__,
...@@ -75,7 +65,7 @@ def req_file(filename): ...@@ -75,7 +65,7 @@ def req_file(filename):
install_requires = req_file("requirements.txt") install_requires = req_file("requirements.txt")
setuptools.setup( setuptools.setup(
name=__package_name__ + '_test', name=__package_name__,
# Versions should comply with PEP440. For a discussion on single-sourcing # Versions should comply with PEP440. For a discussion on single-sourcing
# the version across setup.py and the project code, see # the version across setup.py and the project code, see
# https://packaging.python.org/en/latest/single_source_version.html # https://packaging.python.org/en/latest/single_source_version.html
...@@ -130,5 +120,5 @@ setuptools.setup( ...@@ -130,5 +120,5 @@ setuptools.setup(
include_package_data=True, include_package_data=True,
zip_safe=False, zip_safe=False,
# PyPI package information. # PyPI package information.
keywords=__keywords__, keywords=__keywords__
) )
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment