Change encoder_learned_pos default back to True for xlm_base

Reviewed By: pipibjc

Differential Revision: D15635402

fbshipit-source-id: e92fab914de40775d7bad851420355240d822bde

fairseq/models/masked_lm.py

@@ -337,7 +337,7 @@ def xlm_architecture(args):
         args, 'share_encoder_input_output_embed', True)
     args.no_token_positional_embeddings = getattr(
         args, 'no_token_positional_embeddings', False)
-    args.encoder_learned_pos = getattr(args, 'encoder_learned_pos', False)
+    args.encoder_learned_pos = getattr(args, 'encoder_learned_pos', True)
     args.num_segment = getattr(args, 'num_segment', 1)
 
     args.encoder_layers = getattr(args, 'encoder_layers', 6)

tests/test_binaries.py

@@ -262,7 +262,7 @@ class TestMaskedLanguageModel(unittest.TestCase):
             with tempfile.TemporaryDirectory("test_mlm") as data_dir:
                 create_dummy_data(data_dir)
                 preprocess_lm_data(data_dir)
-                train_masked_language_model(data_dir, "xlm_base")
+                train_masked_language_model(data_dir, "masked_lm")
 
     def _test_pretrained_masked_lm_for_translation(self, learned_pos_emb, encoder_only):
         with contextlib.redirect_stdout(StringIO()):
@@ -271,7 +271,7 @@ class TestMaskedLanguageModel(unittest.TestCase):
                 preprocess_lm_data(data_dir)
                 train_masked_language_model(
                     data_dir,
-                    arch="xlm_base",
+                    arch="masked_lm",
                     extra_args=('--encoder-learned-pos',) if learned_pos_emb else ()
                 )
                 with tempfile.TemporaryDirectory(