Commit 5be1cf30 authored by Myle Ott's avatar Myle Ott Committed by Facebook Github Bot
Browse files

Fix bug in forward_embedding (#931)

Summary:
See: https://twitter.com/nymwa/status/1200684169115734016
Pull Request resolved: https://github.com/fairinternal/fairseq-py/pull/931

Differential Revision: D18782345

Pulled By: myleott

fbshipit-source-id: 9e74287a8ce677237042c5fdbe0bdbd4774b5ce6
parent 10c2e8c1
...@@ -353,7 +353,7 @@ class TransformerEncoder(FairseqEncoder): ...@@ -353,7 +353,7 @@ class TransformerEncoder(FairseqEncoder):
def forward_embedding(self, src_tokens): def forward_embedding(self, src_tokens):
# embed tokens and positions # embed tokens and positions
embed = self.embed_scale * self.embed_tokens(src_tokens) x = embed = self.embed_scale * self.embed_tokens(src_tokens)
if self.embed_positions is not None: if self.embed_positions is not None:
x = embed + self.embed_positions(src_tokens) x = embed + self.embed_positions(src_tokens)
if self.layernorm_embedding: if self.layernorm_embedding:
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment