Unverified Commit c8d32c30 authored by Min Xu's avatar Min Xu Committed by GitHub
Browse files

[chore] Updating PR template (#674)

* [chore] Updating PR template

Add N/A (Not Applicable) options to some of the questions in the PR template

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md
parent 6c61887d
# Before submitting ## What does this PR do?
Fixes # (issue).
- [ ] Was this discussed/approved via a Github issue? (no need for typos, doc improvements) ## Before submitting
- [ ] Did you have fun?
- Make sure you had fun coding 🙃
- [ ] Did you read the [contributor guideline](https://github.com/facebookresearch/fairscale/blob/master/CONTRIBUTING.md)? - [ ] Did you read the [contributor guideline](https://github.com/facebookresearch/fairscale/blob/master/CONTRIBUTING.md)?
- [ ] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
- [ ] N/A
- [ ] Did you make sure to update the docs? - [ ] Did you make sure to update the docs?
- [ ] N/A
- [ ] Did you write any new necessary tests? - [ ] Did you write any new necessary tests?
- [ ] N/A
- [ ] Did you update the [changelog](https://github.com/facebookresearch/fairscale/blob/master/CHANGELOG.md)? (if needed) - [ ] Did you update the [changelog](https://github.com/facebookresearch/fairscale/blob/master/CHANGELOG.md)? (if needed)
- [ ] N/A
## What does this PR do?
Fixes # (issue).
## PR review ## PR review
Anyone in the community is free to review the PR once the tests have passed. Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
## Did you have fun?
Make sure you had fun coding 🙃
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment