Unverified Commit 5f484b35 authored by Vlad Tiberiu Mihailescu's avatar Vlad Tiberiu Mihailescu Committed by GitHub
Browse files

Add timeout in initialize_model_parallel (#1182)

We need a timeout to react faster when one of the partitions is broken
parent 4d26a67c
Pipeline #1034 failed with stages
in 0 seconds
...@@ -23,6 +23,7 @@ ...@@ -23,6 +23,7 @@
from typing import List, Optional from typing import List, Optional
import torch import torch
from datetime import timedelta
from .utils import ensure_divisibility from .utils import ensure_divisibility
...@@ -47,6 +48,7 @@ def initialize_model_parallel( ...@@ -47,6 +48,7 @@ def initialize_model_parallel(
pipeline_backend: Optional[str] = None, pipeline_backend: Optional[str] = None,
cp_backend: Optional[str] = None, cp_backend: Optional[str] = None,
ddp_backend: Optional[str] = None, ddp_backend: Optional[str] = None,
timeout: Optional[timedelta] = None,
) -> None: ) -> None:
""" """
Initialize model data parallel groups. Initialize model data parallel groups.
...@@ -112,7 +114,7 @@ def initialize_model_parallel( ...@@ -112,7 +114,7 @@ def initialize_model_parallel(
for i in range(pipeline_length): for i in range(pipeline_length):
for j in range(context_parallel_size): for j in range(context_parallel_size):
for k in range(model_parallel_size): for k in range(model_parallel_size):
group = torch.distributed.new_group(groups[:, i, j, k].tolist(), backend=ddp_backend) group = torch.distributed.new_group(groups[:, i, j, k].tolist(), backend=ddp_backend, timeout=timeout)
if i == found[1] and j == found[2] and k == found[3]: if i == found[1] and j == found[2] and k == found[3]:
_DATA_PARALLEL_GROUP = group _DATA_PARALLEL_GROUP = group
...@@ -123,7 +125,7 @@ def initialize_model_parallel( ...@@ -123,7 +125,7 @@ def initialize_model_parallel(
for i in range(data_parallel_size): for i in range(data_parallel_size):
for j in range(pipeline_length): for j in range(pipeline_length):
for k in range(context_parallel_size): for k in range(context_parallel_size):
group = torch.distributed.new_group(groups[i, j, k, :].tolist(), backend=model_parallel_backend) group = torch.distributed.new_group(groups[i, j, k, :].tolist(), backend=model_parallel_backend, timeout=timeout)
if i == found[0] and j == found[1] and k == found[2]: if i == found[0] and j == found[1] and k == found[2]:
_MODEL_PARALLEL_GROUP = group _MODEL_PARALLEL_GROUP = group
...@@ -136,7 +138,7 @@ def initialize_model_parallel( ...@@ -136,7 +138,7 @@ def initialize_model_parallel(
for j in range(context_parallel_size): for j in range(context_parallel_size):
for k in range(model_parallel_size): for k in range(model_parallel_size):
ranks = groups[i, :, j, k].tolist() ranks = groups[i, :, j, k].tolist()
group = torch.distributed.new_group(ranks, backend=pipeline_backend) group = torch.distributed.new_group(ranks, backend=pipeline_backend, timeout=timeout)
if i == found[0] and j == found[2] and k == found[3]: if i == found[0] and j == found[2] and k == found[3]:
_PIPELINE_PARALLEL_GROUP = group _PIPELINE_PARALLEL_GROUP = group
_PIPELINE_PARALLEL_RANKS = ranks _PIPELINE_PARALLEL_RANKS = ranks
...@@ -153,7 +155,7 @@ def initialize_model_parallel( ...@@ -153,7 +155,7 @@ def initialize_model_parallel(
for j in range(pipeline_length): for j in range(pipeline_length):
for k in range(model_parallel_size): for k in range(model_parallel_size):
ranks = groups[i, j, :, k].tolist() ranks = groups[i, j, :, k].tolist()
group = torch.distributed.new_group(ranks, backend=cp_backend) group = torch.distributed.new_group(ranks, backend=cp_backend, timeout=timeout)
if i == found[0] and j == found[1] and k == found[3]: if i == found[0] and j == found[1] and k == found[3]:
_CONTEXT_PARALLEL_GROUP = group _CONTEXT_PARALLEL_GROUP = group
_CONTEXT_PARALLEL_GROUP_RANKS = ranks _CONTEXT_PARALLEL_GROUP_RANKS = ranks
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment