Unverified Commit e3ba40e8 authored by Dillon Cullinan's avatar Dillon Cullinan Committed by GitHub
Browse files

ci: Fix frontend pod detection in deploy tests (#4054)


Signed-off-by: default avatarDillon Cullinan <dcullinan@nvidia.com>
parent dadf0e22
...@@ -344,7 +344,7 @@ jobs: ...@@ -344,7 +344,7 @@ jobs:
deploy-operator: deploy-operator:
runs-on: cpu-amd-m5-2xlarge runs-on: cpu-amd-m5-2xlarge
if: needs.changed-files.outputs.has_code_changes == 'true' if: needs.changed-files.outputs.has_code_changes == 'true'
needs: [changed-files, operator] needs: [changed-files, operator, vllm, sglang, trtllm]
env: env:
DYNAMO_INGRESS_SUFFIX: dev.aire.nvidia.com DYNAMO_INGRESS_SUFFIX: dev.aire.nvidia.com
outputs: outputs:
...@@ -455,6 +455,7 @@ jobs: ...@@ -455,6 +455,7 @@ jobs:
export FRAMEWORK_RUNTIME_IMAGE="${{ secrets.AZURE_ACR_HOSTNAME }}/ai-dynamo/dynamo:${{ github.sha }}-${FRAMEWORK}-amd64" export FRAMEWORK_RUNTIME_IMAGE="${{ secrets.AZURE_ACR_HOSTNAME }}/ai-dynamo/dynamo:${{ github.sha }}-${FRAMEWORK}-amd64"
export KUBE_NS=$NAMESPACE export KUBE_NS=$NAMESPACE
export GRAPH_NAME=$(yq e '.metadata.name' $DEPLOYMENT_FILE) export GRAPH_NAME=$(yq e '.metadata.name' $DEPLOYMENT_FILE)
echo "GRAPH_NAME=${GRAPH_NAME}" >> $GITHUB_ENV
# Update the deployment file in-place # Update the deployment file in-place
yq -i '.spec.services.[].extraPodSpec.mainContainer.image = env(FRAMEWORK_RUNTIME_IMAGE)' $DEPLOYMENT_FILE yq -i '.spec.services.[].extraPodSpec.mainContainer.image = env(FRAMEWORK_RUNTIME_IMAGE)' $DEPLOYMENT_FILE
...@@ -479,7 +480,7 @@ jobs: ...@@ -479,7 +480,7 @@ jobs:
echo "" echo ""
kubectl get all -n $KUBE_NS kubectl get all -n $KUBE_NS
export FRONTEND_POD=$(kubectl get pods -n ${KUBE_NS} | grep "frontend" | sort -k1 | tail -n1 | awk '{print $1}') export FRONTEND_POD=$(kubectl get pods -n ${KUBE_NS} | grep ${GRAPH_NAME}-frontend | sort -k1 | tail -n1 | awk '{print $1}')
export CONTAINER_PORT=$(kubectl get pod $FRONTEND_POD -n ${KUBE_NS} -o jsonpath='{.spec.containers[0].ports[?(@.name=="http")].containerPort}') export CONTAINER_PORT=$(kubectl get pod $FRONTEND_POD -n ${KUBE_NS} -o jsonpath='{.spec.containers[0].ports[?(@.name=="http")].containerPort}')
echo "Container port is ${CONTAINER_PORT}" echo "Container port is ${CONTAINER_PORT}"
kubectl port-forward pod/$FRONTEND_POD 8000:${CONTAINER_PORT} -n ${KUBE_NS} & kubectl port-forward pod/$FRONTEND_POD 8000:${CONTAINER_PORT} -n ${KUBE_NS} &
...@@ -547,7 +548,6 @@ jobs: ...@@ -547,7 +548,6 @@ jobs:
timeout-minutes: 5 timeout-minutes: 5
env: env:
NAMESPACE: ${{ needs.deploy-operator.outputs.NAMESPACE }} NAMESPACE: ${{ needs.deploy-operator.outputs.NAMESPACE }}
PROFILE: ${{ matrix.profile }}
run: | run: |
set -x set -x
export KUBECONFIG=$(pwd)/.kubeconfig export KUBECONFIG=$(pwd)/.kubeconfig
...@@ -557,8 +557,7 @@ jobs: ...@@ -557,8 +557,7 @@ jobs:
kubectl get all kubectl get all
echo "Deleting DynamoGraphDeployments for this job in namespace $NAMESPACE..." echo "Deleting DynamoGraphDeployments for this job in namespace $NAMESPACE..."
PROFILE_SANITIZED="${PROFILE/_/-}" kubectl delete dynamographdeployments ${GRAPH_NAME} -n $NAMESPACE || true
kubectl delete dynamographdeployments $FRAMEWORK-$PROFILE_SANITIZED -n $NAMESPACE || true
deploy-test-sglang: deploy-test-sglang:
runs-on: cpu-amd-m5-2xlarge runs-on: cpu-amd-m5-2xlarge
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment