Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
dynamo
Commits
dfd3aa99
Unverified
Commit
dfd3aa99
authored
Apr 22, 2026
by
hhzhang16
Committed by
GitHub
Apr 22, 2026
Browse files
feat: address MR comments from TRTLLM/GMS integration (#8255)
Signed-off-by:
Hannah Zhang
<
hannahz@nvidia.com
>
parent
d07288c5
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
12 deletions
+11
-12
components/src/dynamo/trtllm/request_handlers/handler_base.py
...onents/src/dynamo/trtllm/request_handlers/handler_base.py
+2
-7
components/src/dynamo/trtllm/tests/test_trtllm_sleep_wake_handlers.py
...rc/dynamo/trtllm/tests/test_trtllm_sleep_wake_handlers.py
+9
-5
No files found.
components/src/dynamo/trtllm/request_handlers/handler_base.py
View file @
dfd3aa99
...
...
@@ -107,13 +107,8 @@ class TRTLLMEngineQuiesceController:
"TRT-LLM does not expose _collective_rpc; skipping %s"
,
method
)
return
try
:
rpc
(
method
,
args
=
(
rpc_tags
,),
kwargs
=
{},
non_block
=
False
)
except
Exception
:
if
method
!=
"wakeup"
:
raise
# Some TRT-LLM versions use "wake_up" instead of "wakeup"
rpc
(
"wake_up"
,
args
=
(
rpc_tags
,),
kwargs
=
{},
non_block
=
False
)
@
staticmethod
def
_release_gms_weights
()
->
None
:
...
...
components/src/dynamo/trtllm/tests/test_trtllm_sleep_wake_handlers.py
View file @
dfd3aa99
...
...
@@ -53,10 +53,17 @@ def _make_handler() -> _ConcreteHandler:
handler
.
_no_inflight_requests
=
asyncio
.
Event
()
handler
.
_no_inflight_requests
.
set
()
handler
.
_reject_new_requests
=
False
# Mock the quiesce controller that release/resume delegate to
# Mock the quiesce controller that release/resume delegate to.
# quiesce side_effect mirrors the real implementation;
# tests don't need to manually update state after a release call.
handler
.
_quiesce_controller
=
MagicMock
()
handler
.
_quiesce_controller
.
is_quiesced
=
False
handler
.
_quiesce_controller
.
quiesce
=
AsyncMock
(
return_value
=
True
)
async
def
_quiesce
(
tags
=
None
):
handler
.
_quiesce_controller
.
is_quiesced
=
True
return
True
handler
.
_quiesce_controller
.
quiesce
=
AsyncMock
(
side_effect
=
_quiesce
)
handler
.
_quiesce_controller
.
resume
=
AsyncMock
(
return_value
=
True
)
handler
.
_quiesce_controller
.
mark_resumed
=
MagicMock
()
return
handler
...
...
@@ -165,9 +172,6 @@ async def test_release_and_resume_round_trip():
release
=
await
handler
.
release_memory_occupation
({})
assert
release
[
"status"
]
==
"ok"
# After release, controller reports quiesced
handler
.
_quiesce_controller
.
is_quiesced
=
True
resume
=
await
handler
.
resume_memory_occupation
({})
assert
resume
[
"status"
]
==
"ok"
handler
.
_quiesce_controller
.
resume
.
assert_awaited_once
()
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment