"docs/backends/vscode:/vscode.git/clone" did not exist on "6cd6033c7c1b3fb0b9a40c4337c0f770487483d9"
Unverified Commit db5687f5 authored by Julien Debache's avatar Julien Debache Committed by GitHub
Browse files

fix: adjust usage of vLLM for deprecation of 'disable_log_requests' (#4659)


Co-authored-by: default avatarRyan McCormick <rmccormick@nvidia.com>
parent 2f2a13a3
...@@ -464,7 +464,7 @@ def overwrite_args(config): ...@@ -464,7 +464,7 @@ def overwrite_args(config):
# skip tokenizer initialisation. Setting this to **False** avoids # skip tokenizer initialisation. Setting this to **False** avoids
# a NoneType error when the processor accesses the tokenizer. # a NoneType error when the processor accesses the tokenizer.
"skip_tokenizer_init": False, "skip_tokenizer_init": False,
"disable_log_requests": True, "enable_log_requests": False,
"disable_log_stats": False, "disable_log_stats": False,
} }
......
...@@ -296,7 +296,7 @@ def setup_vllm_engine(config, stat_logger=None): ...@@ -296,7 +296,7 @@ def setup_vllm_engine(config, stat_logger=None):
vllm_config=vllm_config, vllm_config=vllm_config,
usage_context=usage_context, usage_context=usage_context,
stat_loggers=factory, stat_loggers=factory,
disable_log_requests=engine_args.disable_log_requests, enable_log_requests=engine_args.enable_log_requests,
disable_log_stats=engine_args.disable_log_stats, disable_log_stats=engine_args.disable_log_stats,
) )
......
...@@ -142,7 +142,7 @@ class VllmBaseWorker: ...@@ -142,7 +142,7 @@ class VllmBaseWorker:
vllm_config=vllm_config, vllm_config=vllm_config,
usage_context=usage_context, usage_context=usage_context,
stat_loggers=[self.stats_logger], stat_loggers=[self.stats_logger],
disable_log_requests=self.engine_args.disable_log_requests, enable_log_requests=self.engine_args.enable_log_requests,
disable_log_stats=self.engine_args.disable_log_stats, disable_log_stats=self.engine_args.disable_log_stats,
) )
......
...@@ -155,7 +155,7 @@ def overwrite_args(config): ...@@ -155,7 +155,7 @@ def overwrite_args(config):
defaults = { defaults = {
"task": "generate", "task": "generate",
"skip_tokenizer_init": False, "skip_tokenizer_init": False,
"disable_log_requests": True, "enable_log_requests": False,
"enable_prefix_caching": True, "enable_prefix_caching": True,
# KV routing relies on logging KV metrics # KV routing relies on logging KV metrics
"disable_log_stats": False, "disable_log_stats": False,
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment