Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
dynamo
Commits
cf269dba
Unverified
Commit
cf269dba
authored
Dec 10, 2025
by
Anant Sharma
Committed by
GitHub
Dec 10, 2025
Browse files
ci: re enable sgl unit tests and remove pyproject.toml from runtime image (#4803)
Signed-off-by:
Anant Sharma
<
anants@nvidia.com
>
parent
cc2ee1ed
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
1 addition
and
12 deletions
+1
-12
components/src/dynamo/sglang/tests/test_sglang_unit.py
components/src/dynamo/sglang/tests/test_sglang_unit.py
+1
-10
container/Dockerfile.sglang
container/Dockerfile.sglang
+0
-1
container/Dockerfile.trtllm
container/Dockerfile.trtllm
+0
-1
No files found.
components/src/dynamo/sglang/tests/test_sglang_unit.py
View file @
cf269dba
...
...
@@ -9,8 +9,7 @@ from pathlib import Path
import
pytest
# Runs into segfaults, uncomment when resolved and enable tests
# from dynamo.sglang.args import parse_args
from
dynamo.sglang.args
import
parse_args
from
dynamo.sglang.tests.conftest
import
make_cli_args_fixture
# Get path relative to this test file
...
...
@@ -26,9 +25,7 @@ pytestmark = [
pytest
.
mark
.
sglang
,
pytest
.
mark
.
gpu_1
,
pytest
.
mark
.
pre_merge
,
pytest
.
mark
.
skip
(
reason
=
"Running into segfaults in CI"
),
]
# Create SGLang-specific CLI args fixture
# This will use monkeypatch to write to argv
mock_sglang_cli
=
make_cli_args_fixture
(
"dynamo.sglang"
)
...
...
@@ -37,8 +34,6 @@ mock_sglang_cli = make_cli_args_fixture("dynamo.sglang")
@
pytest
.
mark
.
asyncio
async
def
test_custom_jinja_template_invalid_path
(
mock_sglang_cli
):
"""Test that invalid file path raises FileNotFoundError."""
from
dynamo.sglang.args
import
parse_args
invalid_path
=
"/nonexistent/path/to/template.jinja"
mock_sglang_cli
(
"--model"
,
"Qwen/Qwen3-0.6B"
,
"--custom-jinja-template"
,
invalid_path
...
...
@@ -54,8 +49,6 @@ async def test_custom_jinja_template_invalid_path(mock_sglang_cli):
@
pytest
.
mark
.
asyncio
async
def
test_custom_jinja_template_valid_path
(
mock_sglang_cli
):
"""Test that valid absolute path is stored correctly."""
from
dynamo.sglang.args
import
parse_args
mock_sglang_cli
(
model
=
"Qwen/Qwen3-0.6B"
,
custom_jinja_template
=
JINJA_TEMPLATE_PATH
)
config
=
await
parse_args
(
sys
.
argv
[
1
:])
...
...
@@ -69,8 +62,6 @@ async def test_custom_jinja_template_valid_path(mock_sglang_cli):
@
pytest
.
mark
.
asyncio
async
def
test_custom_jinja_template_env_var_expansion
(
monkeypatch
,
mock_sglang_cli
):
"""Test that environment variables in paths are expanded by Python code."""
from
dynamo.sglang.args
import
parse_args
jinja_dir
=
str
(
TEST_DIR
/
"serve"
/
"fixtures"
)
monkeypatch
.
setenv
(
"JINJA_DIR"
,
jinja_dir
)
...
...
container/Dockerfile.sglang
View file @
cf269dba
...
...
@@ -680,7 +680,6 @@ COPY --chmod=664 --chown=dynamo:0 ATTRIBUTION* LICENSE /workspace/
# Copy tests, benchmarks, deploy and components for CI with correct ownership
# Pattern: COPY --chmod=775 <path>; chmod g+w <path> done later as root because COPY --chmod only affects <path>/*, not <path>
COPY --chmod=775 --chown=dynamo:0 pyproject.toml /workspace/
COPY --chmod=775 --chown=dynamo:0 tests /workspace/tests
COPY --chmod=775 --chown=dynamo:0 examples /workspace/examples
COPY --chmod=775 --chown=dynamo:0 benchmarks /workspace/benchmarks
...
...
container/Dockerfile.trtllm
View file @
cf269dba
...
...
@@ -678,7 +678,6 @@ RUN --mount=type=bind,source=./container/deps/requirements.txt,target=/tmp/requi
# Copy tests, deploy and components for CI with correct ownership
# Pattern: COPY --chmod=775 <path>; chmod g+w <path> done later as root because COPY --chmod only affects <path>/*, not <path>
COPY --chmod=775 --chown=dynamo:0 pyproject.toml /workspace/
COPY --chmod=775 --chown=dynamo:0 tests /workspace/tests
COPY --chmod=775 --chown=dynamo:0 examples /workspace/examples
COPY --chmod=775 --chown=dynamo:0 deploy /workspace/deploy
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment