Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
dynamo
Commits
ca3daddc
Unverified
Commit
ca3daddc
authored
Oct 17, 2025
by
Neelay Shah
Committed by
GitHub
Oct 18, 2025
Browse files
fix: make --mount-workspace interactive behavior explicit (#3582)
Signed-off-by:
Neelay Shah
<
neelays@nvidia.com
>
parent
57cdb9a1
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
11 deletions
+9
-11
container/README.md
container/README.md
+9
-9
container/run.sh
container/run.sh
+0
-2
No files found.
container/README.md
View file @
ca3daddc
...
...
@@ -86,7 +86,7 @@ run.sh ...
### 2. local-dev + `run.sh` (runs as the local user):
```
bash
run.sh
--mount-workspace
--image
dynamo:latest-vllm-local-dev ...
run.sh
--mount-workspace
-it
--image
dynamo:latest-vllm-local-dev ...
```
### 3. local-dev + Dev Container Extension:
...
...
@@ -177,22 +177,22 @@ The `run.sh` script launches Docker containers with the appropriate configuratio
./run.sh
--image
dynamo:latest-vllm
-v
$HOME
/.cache:/home/ubuntu/.cache
# Mount workspace for development (use local-dev image for local host user permissions)
./run.sh
--image
dynamo:latest-vllm-local-dev
--mount-workspace
-v
$HOME
/.cache:/home/ubuntu/.cache
./run.sh
--image
dynamo:latest-vllm-local-dev
--mount-workspace
-it
-v
$HOME
/.cache:/home/ubuntu/.cache
# Use specific image and framework for development
./run.sh
--image
v0.1.0.dev.08cc44965-vllm-local-dev
--framework
vllm
--mount-workspace
-v
$HOME
/.cache:/home/ubuntu/.cache
./run.sh
--image
v0.1.0.dev.08cc44965-vllm-local-dev
--framework
vllm
--mount-workspace
-it
-v
$HOME
/.cache:/home/ubuntu/.cache
# Interactive development shell with workspace mounted
./run.sh
--image
dynamo:latest-vllm-local-dev
--mount-workspace
-v
$HOME
/.cache:/home/ubuntu/.cache
-it
--
bash
# Development with custom environment variables
./run.sh
--image
dynamo:latest-vllm-local-dev
-e
CUDA_VISIBLE_DEVICES
=
0,1
--mount-workspace
-v
$HOME
/.cache:/home/ubuntu/.cache
./run.sh
--image
dynamo:latest-vllm-local-dev
-e
CUDA_VISIBLE_DEVICES
=
0,1
--mount-workspace
-it
-v
$HOME
/.cache:/home/ubuntu/.cache
# Dry run to see docker command
./run.sh
--dry-run
# Development with custom volume mounts
./run.sh
--image
dynamo:latest-vllm-local-dev
-v
/host/path:/container/path
--mount-workspace
-v
$HOME
/.cache:/home/ubuntu/.cache
./run.sh
--image
dynamo:latest-vllm-local-dev
-v
/host/path:/container/path
--mount-workspace
-it
-v
$HOME
/.cache:/home/ubuntu/.cache
```
### Network Configuration Options
...
...
@@ -216,7 +216,7 @@ The `run.sh` script supports different networking modes via the `--network` flag
#### Bridge Networking (Isolated)
```
bash
# CI/testing with isolated bridge networking and host cache sharing
./run.sh
--image
dynamo:latest-vllm
--mount-workspace
--network
bridge
-v
$HOME
/.cache:/home/ubuntu/.cache
./run.sh
--image
dynamo:latest-vllm
--mount-workspace
-it
--network
bridge
-v
$HOME
/.cache:/home/ubuntu/.cache
```
**Use cases:**
-
Secure isolation from host network
...
...
@@ -229,10 +229,10 @@ The `run.sh` script supports different networking modes via the `--network` flag
#### No Networking ⚠️ **LIMITED FUNCTIONALITY**
```
bash
# Complete network isolation - no external connectivity
./run.sh
--image
dynamo:latest-vllm
--network
none
--mount-workspace
-v
$HOME
/.cache:/home/ubuntu/.cache
./run.sh
--image
dynamo:latest-vllm
--network
none
--mount-workspace
-it
-v
$HOME
/.cache:/home/ubuntu/.cache
# Same with local user permissions
./run.sh
--image
dynamo:latest-vllm-local-dev
--network
none
--mount-workspace
-v
$HOME
/.cache:/home/ubuntu/.cache
./run.sh
--image
dynamo:latest-vllm-local-dev
--network
none
--mount-workspace
-it
-v
$HOME
/.cache:/home/ubuntu/.cache
```
**⚠️ WARNING: `--network none` severely limits Dynamo functionality:**
-
**No model downloads**
- HuggingFace models cannot be downloaded
...
...
@@ -307,7 +307,7 @@ python -m dynamo.vllm --model Qwen/Qwen3-0.6B --gpu-memory-utilization 0.20 &
./build.sh
--framework
vllm
--no-cache
# 2. Run tests with network isolation for reproducible results
./run.sh
--image
dynamo:latest-vllm
--mount-workspace
--network
bridge
-v
$HOME
/.cache:/home/ubuntu/.cache
--
python
-m
pytest tests/
./run.sh
--image
dynamo:latest-vllm
--mount-workspace
-it
--network
bridge
-v
$HOME
/.cache:/home/ubuntu/.cache
--
python
-m
pytest tests/
# 3. Inside the container with bridge networking, start services
# Note: Services are only accessible from the same container - no port conflicts with host
...
...
container/run.sh
View file @
ca3daddc
...
...
@@ -259,8 +259,6 @@ get_options() {
fi
ENVIRONMENT_VARIABLES+
=
" -e HF_TOKEN"
INTERACTIVE
=
" -it "
fi
if
[[
${
HF_HOME
^^
}
==
"NONE"
]]
;
then
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment