Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
dynamo
Commits
ac4fd87b
Unverified
Commit
ac4fd87b
authored
Jun 18, 2025
by
Ryan McCormick
Committed by
GitHub
Jun 17, 2025
Browse files
refactor: Log subprocess stderr as WARN (#1563)
parent
84454ab4
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
1 deletion
+5
-1
launch/dynamo-run/src/subprocess.rs
launch/dynamo-run/src/subprocess.rs
+5
-1
No files found.
launch/dynamo-run/src/subprocess.rs
View file @
ac4fd87b
...
...
@@ -98,7 +98,11 @@ pub async fn start(
tokio
::
spawn
(
async
move
{
let
mut
lines
=
stderr
.lines
();
while
let
Ok
(
Some
(
line
))
=
lines
.next_line
()
.await
{
tracing
::
error!
(
"{}"
,
strip_log_prefix
(
&
line
));
// FIXME: always logging INFO/DEBUG will hide real errors, but
// some libraries log non-errors to stderr, which confuses users
// when we log those as ERROR. Using WARN as a middle ground for
// now, but we can probably be smarter here.
tracing
::
warn!
(
"{}"
,
strip_log_prefix
(
&
line
));
}
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment