Unverified Commit 9eee5354 authored by jh-nv's avatar jh-nv Committed by GitHub
Browse files

fix: observability fixes for OTEL tracing and logging (#7240)


Signed-off-by: default avatarJie Hao <jihao@nvidia.com>
parent ae9ffa35
...@@ -20,7 +20,9 @@ datasources: ...@@ -20,7 +20,9 @@ datasources:
filterByTraceID: false filterByTraceID: false
filterBySpanID: false filterBySpanID: false
customQuery: true customQuery: true
query: '{service_name=~".+"} | trace_id = "$${__span.traceId}"' query: '{service_name=~".+"} | trace_id = "$${__trace.traceId}"'
spanStartTimeShift: "-1h"
spanEndTimeShift: "1h"
search: search:
hide: false hide: false
nodeGraph: nodeGraph:
......
...@@ -89,12 +89,15 @@ class VllmColorFormatter(logging.Formatter): ...@@ -89,12 +89,15 @@ class VllmColorFormatter(logging.Formatter):
else: else:
target = record.module target = record.module
msg = record.getMessage() msg = record.getMessage()
return ( result = (
f"{self._DIM}{ts}{self._RESET} " f"{self._DIM}{ts}{self._RESET} "
f"{color}{level:>5}{self._RESET} " f"{color}{level:>5}{self._RESET} "
f"{self._DIM}{target}{self._RESET}{self._DIM}:{self._RESET} " f"{self._DIM}{target}{self._RESET}{self._DIM}:{self._RESET} "
f"{msg}" f"{msg}"
) )
if record.exc_info and record.exc_info[0] is not None:
result += "\n" + self.formatException(record.exc_info)
return result
# Configure the Python logger to use the NimLogHandler # Configure the Python logger to use the NimLogHandler
......
...@@ -50,7 +50,7 @@ trtllm =[ ...@@ -50,7 +50,7 @@ trtllm =[
vllm = [ vllm = [
"uvloop", "uvloop",
"nixl[cu12]<=0.10.1", "nixl[cu12]<=0.10.1",
"vllm[flashinfer,runai]==0.17.1", "vllm[flashinfer,runai,otel]==0.17.1",
# vllm-omni 0.16.0 is now on PyPI; install only future rc builds from source in container builds # vllm-omni 0.16.0 is now on PyPI; install only future rc builds from source in container builds
# (see container/deps/vllm/install_vllm.sh). pip install ai-dynamo[vllm] will # (see container/deps/vllm/install_vllm.sh). pip install ai-dynamo[vllm] will
# not include vllm-omni — install it separately from source if needed. # not include vllm-omni — install it separately from source if needed.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment