Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
dynamo
Commits
7f1f3076
Unverified
Commit
7f1f3076
authored
Mar 05, 2026
by
Julien Mancuso
Committed by
GitHub
Mar 05, 2026
Browse files
fix: fix operator race condition (#6929)
Signed-off-by:
Julien Mancuso
<
jmancuso@nvidia.com
>
parent
876c9761
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
4 deletions
+8
-4
deploy/operator/internal/cert/cert.go
deploy/operator/internal/cert/cert.go
+7
-2
deploy/operator/internal/cert/cert_test.go
deploy/operator/internal/cert/cert_test.go
+1
-2
No files found.
deploy/operator/internal/cert/cert.go
View file @
7f1f3076
...
...
@@ -132,7 +132,12 @@ func (cm *CertManager) setupAutoProvisioning(ctx context.Context, mgr ctrl.Manag
fmt
.
Sprintf
(
"%s.%s.svc.cluster.local"
,
cm
.
cfg
.
ServiceName
,
cm
.
namespace
),
},
EnableReadinessCheck
:
true
,
RestartOnSecretRefresh
:
true
,
// RestartOnSecretRefresh is intentionally false (default). The rotator's
// ensureCertsMounted goroutine polls CertDir until the kubelet projects
// the updated secret, then closes IsReady. The webhook server is only
// started after IsReady fires, so the files are guaranteed to exist.
// Setting this to true would call os.Exit immediately after writing the
// secret, racing the kubelet volume projection on restart.
}
return
cm
.
provisioner
.
AddRotator
(
mgr
,
rotator
)
}
...
...
deploy/operator/internal/cert/cert_test.go
View file @
7f1f3076
...
...
@@ -186,7 +186,6 @@ func TestCertManager_AutoModeConfiguresRotator(t *testing.T) {
fmt
.
Sprintf
(
"%s.%s.svc.cluster.local"
,
testServiceName
,
testNamespace
),
},
EnableReadinessCheck
:
true
,
RestartOnSecretRefresh
:
true
,
}
if
!
reflect
.
DeepEqual
(
prov
.
capturedArgs
,
expected
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment