Skip to content

GitLab

Unverified Commit 6caac575 authored by Tzu-Ling Kan's avatar Tzu-Ling Kan Committed by GitHub
Browse files

fix: turn off DYN_HEALTH_CHECK_ENABLED (#5038) 


Signed-off-by: default avatartzulingk@nvidia.com <tzulingk@nvidia.com>
parent 6979710a
Show whitespace changes
Inline Side-by-side
Showing with 8 additions and 8 deletions
deploy/cloud/operator/internal/controller/dynamocomponentdeployment_controller_test.go
View file @ 6caac575
...@@ -829,7 +829,7 @@ func TestDynamoComponentDeploymentReconciler_generateLeaderWorkerSet(t *testing. ...@@ -829,7 +829,7 @@ func TestDynamoComponentDeploymentReconciler_generateLeaderWorkerSet(t *testing.
Env: []corev1.EnvVar{ Env: []corev1.EnvVar{
{Name: commonconsts.DynamoComponentEnvVar, Value: commonconsts.ComponentTypeWorker}, {Name: commonconsts.DynamoComponentEnvVar, Value: commonconsts.ComponentTypeWorker},
{Name: commonconsts.DynamoDiscoveryBackendEnvVar, Value: "kubernetes"}, {Name: commonconsts.DynamoDiscoveryBackendEnvVar, Value: "kubernetes"},
{Name: "DYN_HEALTH_CHECK_ENABLED", Value: "true"}, {Name: "DYN_HEALTH_CHECK_ENABLED", Value: "false"},
{Name: commonconsts.DynamoNamespaceEnvVar, Value: "default"}, {Name: commonconsts.DynamoNamespaceEnvVar, Value: "default"},
{Name: "DYN_PARENT_DGD_K8S_NAME", Value: "test-lws-deploy"}, {Name: "DYN_PARENT_DGD_K8S_NAME", Value: "test-lws-deploy"},
{Name: "DYN_PARENT_DGD_K8S_NAMESPACE", Value: "default"}, {Name: "DYN_PARENT_DGD_K8S_NAMESPACE", Value: "default"},
...@@ -964,7 +964,7 @@ func TestDynamoComponentDeploymentReconciler_generateLeaderWorkerSet(t *testing. ...@@ -964,7 +964,7 @@ func TestDynamoComponentDeploymentReconciler_generateLeaderWorkerSet(t *testing.
Env: []corev1.EnvVar{ Env: []corev1.EnvVar{
{Name: commonconsts.DynamoComponentEnvVar, Value: commonconsts.ComponentTypeWorker}, {Name: commonconsts.DynamoComponentEnvVar, Value: commonconsts.ComponentTypeWorker},
{Name: commonconsts.DynamoDiscoveryBackendEnvVar, Value: "kubernetes"}, {Name: commonconsts.DynamoDiscoveryBackendEnvVar, Value: "kubernetes"},
{Name: "DYN_HEALTH_CHECK_ENABLED", Value: "true"}, {Name: "DYN_HEALTH_CHECK_ENABLED", Value: "false"},
{Name: commonconsts.DynamoNamespaceEnvVar, Value: "default"}, {Name: commonconsts.DynamoNamespaceEnvVar, Value: "default"},
{Name: "DYN_PARENT_DGD_K8S_NAME", Value: "test-lws-deploy"}, {Name: "DYN_PARENT_DGD_K8S_NAME", Value: "test-lws-deploy"},
{Name: "DYN_PARENT_DGD_K8S_NAMESPACE", Value: "default"}, {Name: "DYN_PARENT_DGD_K8S_NAMESPACE", Value: "default"},
......
deploy/cloud/operator/internal/dynamo/component_worker.go
View file @ 6caac575
...@@ -88,7 +88,7 @@ func (w *WorkerDefaults) GetBaseContainer(context ComponentContext) (corev1.Cont ...@@ -88,7 +88,7 @@ func (w *WorkerDefaults) GetBaseContainer(context ComponentContext) (corev1.Cont
}, },
{ {
Name: "DYN_HEALTH_CHECK_ENABLED", Name: "DYN_HEALTH_CHECK_ENABLED",
Value: "true", Value: "false",
}, },
}...) }...)
......
deploy/cloud/operator/internal/dynamo/graph_test.go
View file @ 6caac575
...@@ -1993,7 +1993,7 @@ func TestGenerateGrovePodCliqueSet(t *testing.T) { ...@@ -1993,7 +1993,7 @@ func TestGenerateGrovePodCliqueSet(t *testing.T) {
}, },
{ {
Name: "DYN_HEALTH_CHECK_ENABLED", Name: "DYN_HEALTH_CHECK_ENABLED",
Value: "true", Value: "false",
}, },
{ {
Name: "DYN_PARENT_DGD_K8S_NAME", Name: "DYN_PARENT_DGD_K8S_NAME",
...@@ -2186,7 +2186,7 @@ func TestGenerateGrovePodCliqueSet(t *testing.T) { ...@@ -2186,7 +2186,7 @@ func TestGenerateGrovePodCliqueSet(t *testing.T) {
}, },
{ {
Name: "DYN_HEALTH_CHECK_ENABLED", Name: "DYN_HEALTH_CHECK_ENABLED",
Value: "true", Value: "false",
}, },
{ {
Name: "DYN_PARENT_DGD_K8S_NAME", Name: "DYN_PARENT_DGD_K8S_NAME",
...@@ -2950,7 +2950,7 @@ func TestGenerateGrovePodCliqueSet(t *testing.T) { ...@@ -2950,7 +2950,7 @@ func TestGenerateGrovePodCliqueSet(t *testing.T) {
}, },
{ {
Name: "DYN_HEALTH_CHECK_ENABLED", Name: "DYN_HEALTH_CHECK_ENABLED",
Value: "true", Value: "false",
}, },
{ {
Name: "DYN_PARENT_DGD_K8S_NAME", Name: "DYN_PARENT_DGD_K8S_NAME",
...@@ -3130,7 +3130,7 @@ func TestGenerateGrovePodCliqueSet(t *testing.T) { ...@@ -3130,7 +3130,7 @@ func TestGenerateGrovePodCliqueSet(t *testing.T) {
}, },
{ {
Name: "DYN_HEALTH_CHECK_ENABLED", Name: "DYN_HEALTH_CHECK_ENABLED",
Value: "true", Value: "false",
}, },
{ {
Name: "DYN_PARENT_DGD_K8S_NAME", Name: "DYN_PARENT_DGD_K8S_NAME",
...@@ -5138,7 +5138,7 @@ func TestGenerateBasePodSpec_Worker(t *testing.T) { ...@@ -5138,7 +5138,7 @@ func TestGenerateBasePodSpec_Worker(t *testing.T) {
{Name: "ANOTHER_CONTAINER_ENV", Value: "true"}, {Name: "ANOTHER_CONTAINER_ENV", Value: "true"},
{Name: commonconsts.DynamoComponentEnvVar, Value: "worker"}, {Name: commonconsts.DynamoComponentEnvVar, Value: "worker"},
{Name: commonconsts.DynamoDiscoveryBackendEnvVar, Value: "kubernetes"}, {Name: commonconsts.DynamoDiscoveryBackendEnvVar, Value: "kubernetes"},
{Name: "DYN_HEALTH_CHECK_ENABLED", Value: "true"}, {Name: "DYN_HEALTH_CHECK_ENABLED", Value: "false"},
{Name: commonconsts.DynamoNamespaceEnvVar, Value: ""}, {Name: commonconsts.DynamoNamespaceEnvVar, Value: ""},
{Name: "DYN_PARENT_DGD_K8S_NAME", Value: "test-deployment"}, {Name: "DYN_PARENT_DGD_K8S_NAME", Value: "test-deployment"},
{Name: "DYN_PARENT_DGD_K8S_NAMESPACE", Value: "default"}, {Name: "DYN_PARENT_DGD_K8S_NAMESPACE", Value: "default"},
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment