"vscode:/vscode.git/clone" did not exist on "3659c82efceddcd0f28be943f8283223773ea591"
Unverified Commit 6bccf099 authored by Keiven C's avatar Keiven C Committed by GitHub
Browse files

feat: deprecate DYN_SYSTEM_ENABLED in favor of DYN_SYSTEM_PORT (#4082)


Signed-off-by: default avatarKeiven Chang <keivenchang@users.noreply.github.com>
Co-authored-by: default avatarKeiven Chang <keivenchang@users.noreply.github.com>
parent d1cf3c2c
...@@ -123,8 +123,6 @@ spec: ...@@ -123,8 +123,6 @@ spec:
memory: "100Gi" memory: "100Gi"
gpu: "1" gpu: "1"
envs: envs:
- name: DYN_SYSTEM_ENABLED
value: "true"
- name: DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS - name: DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS
value: "[\"generate\"]" value: "[\"generate\"]"
- name: DYN_SYSTEM_PORT - name: DYN_SYSTEM_PORT
...@@ -180,8 +178,6 @@ spec: ...@@ -180,8 +178,6 @@ spec:
memory: "100Gi" memory: "100Gi"
gpu: "1" gpu: "1"
envs: envs:
- name: DYN_SYSTEM_ENABLED
value: "true"
- name: DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS - name: DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS
value: "[\"generate\"]" value: "[\"generate\"]"
- name: DYN_SYSTEM_PORT - name: DYN_SYSTEM_PORT
......
...@@ -74,8 +74,6 @@ spec: ...@@ -74,8 +74,6 @@ spec:
memory: "100Gi" memory: "100Gi"
gpu: "2" gpu: "2"
envs: envs:
- name: DYN_SYSTEM_ENABLED
value: "true"
- name: DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS - name: DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS
value: "[\"generate\"]" value: "[\"generate\"]"
- name: DYN_SYSTEM_PORT - name: DYN_SYSTEM_PORT
...@@ -124,8 +122,6 @@ spec: ...@@ -124,8 +122,6 @@ spec:
memory: "100Gi" memory: "100Gi"
gpu: "2" gpu: "2"
envs: envs:
- name: DYN_SYSTEM_ENABLED
value: "true"
- name: DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS - name: DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS
value: "[\"generate\"]" value: "[\"generate\"]"
- name: DYN_SYSTEM_PORT - name: DYN_SYSTEM_PORT
......
...@@ -74,8 +74,6 @@ spec: ...@@ -74,8 +74,6 @@ spec:
memory: "100Gi" memory: "100Gi"
gpu: "1" gpu: "1"
envs: envs:
- name: DYN_SYSTEM_ENABLED
value: "true"
- name: DYN_SYSTEM_PORT - name: DYN_SYSTEM_PORT
value: "9090" value: "9090"
- name: DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS - name: DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS
...@@ -124,8 +122,6 @@ spec: ...@@ -124,8 +122,6 @@ spec:
memory: "100Gi" memory: "100Gi"
gpu: "1" gpu: "1"
envs: envs:
- name: DYN_SYSTEM_ENABLED
value: "true"
- name: DYN_SYSTEM_PORT - name: DYN_SYSTEM_PORT
value: "9090" value: "9090"
- name: DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS - name: DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS
......
...@@ -576,6 +576,10 @@ class DynamoFrontendProcess(ManagedProcess): ...@@ -576,6 +576,10 @@ class DynamoFrontendProcess(ManagedProcess):
def __init__(self, request): def __init__(self, request):
command = ["python", "-m", "dynamo.frontend", "--router-mode", "round-robin"] command = ["python", "-m", "dynamo.frontend", "--router-mode", "round-robin"]
# Unset DYN_SYSTEM_PORT - frontend doesn't use system metrics server
env = os.environ.copy()
env.pop("DYN_SYSTEM_PORT", None)
log_dir = f"{request.node.name}_frontend" log_dir = f"{request.node.name}_frontend"
# Clean up any existing log directory from previous runs # Clean up any existing log directory from previous runs
...@@ -588,6 +592,7 @@ class DynamoFrontendProcess(ManagedProcess): ...@@ -588,6 +592,7 @@ class DynamoFrontendProcess(ManagedProcess):
super().__init__( super().__init__(
command=command, command=command,
env=env,
display_output=True, display_output=True,
terminate_existing=True, terminate_existing=True,
log_dir=log_dir, log_dir=log_dir,
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment