Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
OpenDAS
dynamo
Commits
6a93d2c7
Commit
6a93d2c7
authored
Mar 14, 2025
by
Ryan McCormick
Committed by
GitHub
Mar 14, 2025
Browse files
refactor: Update default log level to INFO and promote/demote a few log messages (#159)
parent
c1c22703
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
8 additions
and
6 deletions
+8
-6
components/metrics/src/main.rs
components/metrics/src/main.rs
+3
-3
launch/dynamo-run/src/main.rs
launch/dynamo-run/src/main.rs
+3
-1
lib/runtime/src/logging.rs
lib/runtime/src/logging.rs
+2
-2
No files found.
components/metrics/src/main.rs
View file @
6a93d2c7
...
@@ -115,7 +115,7 @@ fn get_config(args: &Args) -> Result<LLMWorkerLoadCapacityConfig> {
...
@@ -115,7 +115,7 @@ fn get_config(args: &Args) -> Result<LLMWorkerLoadCapacityConfig> {
async
fn
app
(
runtime
:
Runtime
)
->
Result
<
()
>
{
async
fn
app
(
runtime
:
Runtime
)
->
Result
<
()
>
{
let
args
=
Args
::
parse
();
let
args
=
Args
::
parse
();
let
config
=
get_config
(
&
args
)
?
;
let
config
=
get_config
(
&
args
)
?
;
tracing
::
info
!
(
"Config: {config:?}"
);
tracing
::
debug
!
(
"Config: {config:?}"
);
let
drt
=
DistributedRuntime
::
from_settings
(
runtime
.clone
())
.await
?
;
let
drt
=
DistributedRuntime
::
from_settings
(
runtime
.clone
())
.await
?
;
...
@@ -124,7 +124,7 @@ async fn app(runtime: Runtime) -> Result<()> {
...
@@ -124,7 +124,7 @@ async fn app(runtime: Runtime) -> Result<()> {
// Create unique instance of Count
// Create unique instance of Count
let
key
=
format!
(
"{}/instance"
,
component
.etcd_path
());
let
key
=
format!
(
"{}/instance"
,
component
.etcd_path
());
tracing
::
info
!
(
"Creating unique instance of Count at {key}"
);
tracing
::
debug
!
(
"Creating unique instance of Count at {key}"
);
drt
.etcd_client
()
drt
.etcd_client
()
.kv_create
(
.kv_create
(
key
,
key
,
...
@@ -178,7 +178,7 @@ async fn app(runtime: Runtime) -> Result<()> {
...
@@ -178,7 +178,7 @@ async fn app(runtime: Runtime) -> Result<()> {
tokio
::
spawn
(
async
move
{
tokio
::
spawn
(
async
move
{
match
namespace_clone
.subscribe
(
kv_hit_rate_subject
)
.await
{
match
namespace_clone
.subscribe
(
kv_hit_rate_subject
)
.await
{
Ok
(
mut
subscriber
)
=>
{
Ok
(
mut
subscriber
)
=>
{
tracing
::
info
!
(
"Successfully subscribed to KV hit rate events"
);
tracing
::
debug
!
(
"Successfully subscribed to KV hit rate events"
);
while
let
Some
(
msg
)
=
subscriber
.next
()
.await
{
while
let
Some
(
msg
)
=
subscriber
.next
()
.await
{
match
serde_json
::
from_slice
::
<
KVHitRateEvent
>
(
&
msg
.payload
)
{
match
serde_json
::
from_slice
::
<
KVHitRateEvent
>
(
&
msg
.payload
)
{
...
...
launch/dynamo-run/src/main.rs
View file @
6a93d2c7
...
@@ -164,7 +164,9 @@ async fn wrapper(runtime: dynamo_runtime::Runtime) -> anyhow::Result<()> {
...
@@ -164,7 +164,9 @@ async fn wrapper(runtime: dynamo_runtime::Runtime) -> anyhow::Result<()> {
}
}
None
=>
{
None
=>
{
let
default_engine
=
Output
::
default
();
// smart default based on feature flags
let
default_engine
=
Output
::
default
();
// smart default based on feature flags
tracing
::
debug!
(
"Using engine: {default_engine}"
);
tracing
::
info!
(
"Using default engine: {default_engine}. Use out=<engine> to specify an engine."
);
default_engine
default_engine
}
}
};
};
...
...
lib/runtime/src/logging.rs
View file @
6a93d2c7
...
@@ -25,7 +25,7 @@
...
@@ -25,7 +25,7 @@
//!
//!
//! Filters can be configured using the `DYN_LOG` environment variable or by setting the `filters`
//! Filters can be configured using the `DYN_LOG` environment variable or by setting the `filters`
//! key in the TOML configuration file. Filters are comma-separated key-value pairs where the key
//! key in the TOML configuration file. Filters are comma-separated key-value pairs where the key
//! is the crate or module name and the value is the log level. The default log level is `
error
`.
//! is the crate or module name and the value is the log level. The default log level is `
info
`.
//!
//!
//! Example:
//! Example:
//! ```toml
//! ```toml
...
@@ -56,7 +56,7 @@ use tracing_subscriber::{filter::Directive, fmt};
...
@@ -56,7 +56,7 @@ use tracing_subscriber::{filter::Directive, fmt};
const
FILTER_ENV
:
&
str
=
"DYN_LOG"
;
const
FILTER_ENV
:
&
str
=
"DYN_LOG"
;
/// Default log level
/// Default log level
const
DEFAULT_FILTER_LEVEL
:
&
str
=
"
error
"
;
const
DEFAULT_FILTER_LEVEL
:
&
str
=
"
info
"
;
/// ENV used to set the path to the logging configuration file
/// ENV used to set the path to the logging configuration file
const
CONFIG_PATH_ENV
:
&
str
=
"DYN_LOGGING_CONFIG_PATH"
;
const
CONFIG_PATH_ENV
:
&
str
=
"DYN_LOGGING_CONFIG_PATH"
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment