Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
dynamo
Commits
69797b5a
Unverified
Commit
69797b5a
authored
Nov 19, 2025
by
Graham King
Committed by
GitHub
Nov 19, 2025
Browse files
feat: Only monitor NATS metrics if using NATS request plane (#4442)
Signed-off-by:
Graham King
<
grahamk@nvidia.com
>
parent
a8e5328e
Changes
44
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
4 additions
and
6 deletions
+4
-6
lib/runtime/src/runtime.rs
lib/runtime/src/runtime.rs
+2
-2
lib/runtime/tests/namespace_etcd_path.rs
lib/runtime/tests/namespace_etcd_path.rs
+2
-2
tests/frontend/grpc/echo_tensor_worker.py
tests/frontend/grpc/echo_tensor_worker.py
+0
-1
tests/serve/launch/template_verifier.py
tests/serve/launch/template_verifier.py
+0
-1
No files found.
lib/runtime/src/runtime.rs
View file @
69797b5a
...
@@ -324,9 +324,9 @@ impl Runtime {
...
@@ -324,9 +324,9 @@ impl Runtime {
tracker
.wait_for_completion
()
.await
;
tracker
.wait_for_completion
()
.await
;
}
}
// Phase 3: Now connections will be disconnected to NATS/ETCD by cancelling the main token
// Phase 3: Now connections will be disconnected to
backend services (e.g.
NATS/ETCD
)
by cancelling the main token
tracing
::
info!
(
tracing
::
info!
(
"Phase 3: All endpoints ended gracefully. Connections to
NATS/ETCD
will now be disconnected"
"Phase 3: All endpoints ended gracefully. Connections to
backend services
will now be disconnected"
);
);
main_token
.cancel
();
main_token
.cancel
();
});
});
...
...
lib/runtime/tests/namespace_etcd_path.rs
View file @
69797b5a
...
@@ -43,7 +43,7 @@ async fn test_recursive_namespace_implementation() {
...
@@ -43,7 +43,7 @@ async fn test_recursive_namespace_implementation() {
let
runtime
=
Runtime
::
from_current
()
.unwrap
();
let
runtime
=
Runtime
::
from_current
()
.unwrap
();
let
config
=
DistributedConfig
{
let
config
=
DistributedConfig
{
store_backend
:
KeyValueStoreSelect
::
Memory
,
store_backend
:
KeyValueStoreSelect
::
Memory
,
nats_config
:
nats
::
ClientOptions
::
default
(),
nats_config
:
Some
(
nats
::
ClientOptions
::
default
()
)
,
request_plane
:
dynamo_runtime
::
distributed
::
RequestPlaneMode
::
default
(),
request_plane
:
dynamo_runtime
::
distributed
::
RequestPlaneMode
::
default
(),
};
};
let
distributed_runtime
=
DistributedRuntime
::
new
(
runtime
,
config
)
.await
.unwrap
();
let
distributed_runtime
=
DistributedRuntime
::
new
(
runtime
,
config
)
.await
.unwrap
();
...
@@ -90,7 +90,7 @@ async fn test_multiple_branches_recursive_namespaces() {
...
@@ -90,7 +90,7 @@ async fn test_multiple_branches_recursive_namespaces() {
let
runtime
=
Runtime
::
from_current
()
.unwrap
();
let
runtime
=
Runtime
::
from_current
()
.unwrap
();
let
config
=
DistributedConfig
{
let
config
=
DistributedConfig
{
store_backend
:
KeyValueStoreSelect
::
Memory
,
store_backend
:
KeyValueStoreSelect
::
Memory
,
nats_config
:
nats
::
ClientOptions
::
default
(),
nats_config
:
Some
(
nats
::
ClientOptions
::
default
()
)
,
request_plane
:
dynamo_runtime
::
distributed
::
RequestPlaneMode
::
default
(),
request_plane
:
dynamo_runtime
::
distributed
::
RequestPlaneMode
::
default
(),
};
};
let
distributed_runtime
=
DistributedRuntime
::
new
(
runtime
,
config
)
.await
.unwrap
();
let
distributed_runtime
=
DistributedRuntime
::
new
(
runtime
,
config
)
.await
.unwrap
();
...
...
tests/frontend/grpc/echo_tensor_worker.py
View file @
69797b5a
...
@@ -16,7 +16,6 @@ from dynamo.runtime import DistributedRuntime, dynamo_worker
...
@@ -16,7 +16,6 @@ from dynamo.runtime import DistributedRuntime, dynamo_worker
@
dynamo_worker
()
@
dynamo_worker
()
async
def
echo_tensor_worker
(
runtime
:
DistributedRuntime
):
async
def
echo_tensor_worker
(
runtime
:
DistributedRuntime
):
component
=
runtime
.
namespace
(
"tensor"
).
component
(
"echo"
)
component
=
runtime
.
namespace
(
"tensor"
).
component
(
"echo"
)
await
component
.
create_service
()
endpoint
=
component
.
endpoint
(
"generate"
)
endpoint
=
component
.
endpoint
(
"generate"
)
...
...
tests/serve/launch/template_verifier.py
View file @
69797b5a
...
@@ -44,7 +44,6 @@ async def main(runtime: DistributedRuntime):
...
@@ -44,7 +44,6 @@ async def main(runtime: DistributedRuntime):
# Create service
# Create service
component
=
runtime
.
namespace
(
"test"
).
component
(
"backend"
)
component
=
runtime
.
namespace
(
"test"
).
component
(
"backend"
)
await
component
.
create_service
()
endpoint
=
component
.
endpoint
(
"generate"
)
endpoint
=
component
.
endpoint
(
"generate"
)
# Use the existing custom template from fixtures
# Use the existing custom template from fixtures
...
...
Prev
1
2
3
Next
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment