Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
dynamo
Commits
58da7cfe
Unverified
Commit
58da7cfe
authored
Nov 13, 2025
by
Graham King
Committed by
GitHub
Nov 13, 2025
Browse files
test(key_value_store): Assert entries() works correctly (#4312)
Signed-off-by:
Graham King
<
grahamk@nvidia.com
>
parent
3cf67ee0
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
79 additions
and
2 deletions
+79
-2
lib/runtime/src/storage/key_value_store/file.rs
lib/runtime/src/storage/key_value_store/file.rs
+30
-0
lib/runtime/src/storage/key_value_store/mem.rs
lib/runtime/src/storage/key_value_store/mem.rs
+28
-1
tests/frontend/grpc/test_tensor_parameters.py
tests/frontend/grpc/test_tensor_parameters.py
+21
-1
No files found.
lib/runtime/src/storage/key_value_store/file.rs
View file @
58da7cfe
...
...
@@ -471,3 +471,33 @@ fn a_to_fs_err(err: anyhow::Error) -> StoreError {
fn
to_fs_err
<
E
:
std
::
error
::
Error
>
(
err
:
E
)
->
StoreError
{
StoreError
::
FilesystemError
(
err
.to_string
())
}
#[cfg(test)]
mod
tests
{
use
std
::
collections
::
HashSet
;
use
crate
::
storage
::
key_value_store
::{
FileStore
,
Key
,
KeyValueBucket
as
_
,
KeyValueStore
as
_
,
};
#[tokio::test]
async
fn
test_entries_full_path
()
{
let
t
=
tempfile
::
tempdir
()
.unwrap
();
let
m
=
FileStore
::
new
(
t
.path
());
let
bucket
=
m
.get_or_create_bucket
(
"v1/tests"
,
None
)
.await
.unwrap
();
let
_
=
bucket
.insert
(
&
Key
::
new
(
"key1/multi/part"
),
"value1"
.into
(),
0
)
.await
.unwrap
();
let
_
=
bucket
.insert
(
&
Key
::
new
(
"key2"
),
"value2"
.into
(),
0
)
.await
.unwrap
();
let
entries
=
bucket
.entries
()
.await
.unwrap
();
let
keys
:
HashSet
<
String
>
=
entries
.into_keys
()
.collect
();
assert
!
(
keys
.contains
(
"v1/tests/key1/multi/part"
));
assert
!
(
keys
.contains
(
"v1/tests/key2"
));
}
}
lib/runtime/src/storage/key_value_store/mem.rs
View file @
58da7cfe
...
...
@@ -220,9 +220,36 @@ impl KeyValueBucket for MemoryBucketRef {
Some
(
bucket
)
=>
Ok
(
bucket
.data
.iter
()
.map
(|(
k
,
(
_
rev
,
v
))|
(
k
.to_string
(),
v
.clone
()))
.map
(|(
k
,
(
_
rev
,
v
))|
(
[
self
.name
.clone
(),
k
.to_string
()
]
.join
(
"/"
)
,
v
.clone
()))
.collect
()),
None
=>
Err
(
StoreError
::
MissingBucket
(
self
.name
.clone
())),
}
}
}
#[cfg(test)]
mod
tests
{
use
std
::
collections
::
HashSet
;
use
crate
::
storage
::
key_value_store
::{
Key
,
KeyValueBucket
as
_
,
KeyValueStore
as
_
,
MemoryStore
,
};
#[tokio::test]
async
fn
test_entries_full_path
()
{
let
m
=
MemoryStore
::
new
();
let
bucket
=
m
.get_or_create_bucket
(
"bucket1"
,
None
)
.await
.unwrap
();
let
_
=
bucket
.insert
(
&
Key
::
new
(
"key1"
),
"value1"
.into
(),
0
)
.await
.unwrap
();
let
_
=
bucket
.insert
(
&
Key
::
new
(
"key2"
),
"value2"
.into
(),
0
)
.await
.unwrap
();
let
entries
=
bucket
.entries
()
.await
.unwrap
();
let
keys
:
HashSet
<
String
>
=
entries
.into_keys
()
.collect
();
assert
!
(
keys
.contains
(
"bucket1/key1"
));
assert
!
(
keys
.contains
(
"bucket1/key2"
));
}
}
tests/frontend/grpc/test_tensor_parameters.py
View file @
58da7cfe
...
...
@@ -6,6 +6,7 @@
import
logging
import
os
import
shutil
import
tempfile
import
numpy
as
np
import
pytest
...
...
@@ -90,6 +91,25 @@ def extract_params(param_map) -> dict:
return
result
@
pytest
.
fixture
def
file_storage_backend
():
"""Fixture that sets up and tears down file storage backend.
Creates a temporary directory for file-based KV storage and sets
the DYN_FILE_KV environment variable. Cleans up after the test.
"""
with
tempfile
.
TemporaryDirectory
()
as
tmpdir
:
old_env
=
os
.
environ
.
get
(
"DYN_FILE_KV"
)
os
.
environ
[
"DYN_FILE_KV"
]
=
tmpdir
logger
.
info
(
f
"Set up file storage backend in:
{
tmpdir
}
"
)
yield
tmpdir
# Cleanup
if
old_env
is
not
None
:
os
.
environ
[
"DYN_FILE_KV"
]
=
old_env
else
:
os
.
environ
.
pop
(
"DYN_FILE_KV"
,
None
)
@
pytest
.
mark
.
e2e
@
pytest
.
mark
.
pre_merge
@
pytest
.
mark
.
parametrize
(
...
...
@@ -101,7 +121,7 @@ def extract_params(param_map) -> dict:
],
ids
=
[
"no_params"
,
"numeric_param"
,
"mixed_params"
],
)
def
test_request_parameters
(
start_services
,
request_params
):
def
test_request_parameters
(
file_storage_backend
,
start_services
,
request_params
):
"""Test gRPC request-level parameters are echoed through tensor models.
The worker acts as an identity function: echoes input tensors unchanged and
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment