Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
dynamo
Commits
47c4bd46
Unverified
Commit
47c4bd46
authored
Apr 13, 2026
by
Alec
Committed by
GitHub
Apr 13, 2026
Browse files
fix(kvbm): query NCCL version at runtime instead of hardcoding (#8130)
Signed-off-by:
Alec Flowers
<
aflowers@nvidia.com
>
parent
9bc6d98d
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
12 additions
and
2 deletions
+12
-2
lib/llm/src/block_manager/distributed/nccl_bootstrap.rs
lib/llm/src/block_manager/distributed/nccl_bootstrap.rs
+12
-2
No files found.
lib/llm/src/block_manager/distributed/nccl_bootstrap.rs
View file @
47c4bd46
...
...
@@ -14,7 +14,7 @@
use
anyhow
::{
Context
,
Result
};
use
cudarc
::
nccl
::
sys
::{
ncclComm_t
,
ncclCommDestroy
,
ncclCommInitRankConfig
,
ncclConfig_t
,
ncclGetUniqueId
,
ncclResult_t
,
ncclUniqueId
,
ncclGetVersion
,
ncclResult_t
,
ncclUniqueId
,
};
/// Check NCCL result and convert to anyhow::Result
...
...
@@ -162,6 +162,16 @@ impl NcclBootstrap {
// We have to manually create it the same way the NCCL C++ macros do.
let
mut
config
:
ncclConfig_t
;
// Query runtime NCCL version instead of hardcoding — avoids
// ncclInvalidUsage when the container's NCCL version doesn't match.
let
nccl_version
=
{
let
mut
v
:
std
::
ffi
::
c_int
=
0
;
let
result
=
unsafe
{
ncclGetVersion
(
&
mut
v
)
};
check_nccl_result
(
result
,
"ncclGetVersion"
)
?
;
tracing
::
debug!
(
"NCCL runtime version: {v}"
);
v
as
std
::
ffi
::
c_uint
};
let
max_ctas
=
std
::
env
::
var
(
"DYN_KVBM_NCCL_MAX_CTAS"
)
.ok
()
.and_then
(|
val
|
val
.parse
::
<
i32
>
()
.ok
())
...
...
@@ -170,7 +180,7 @@ impl NcclBootstrap {
config
=
ncclConfig_t
{
size
:
std
::
mem
::
size_of
::
<
ncclConfig_t
>
(),
magic
:
0xcafebeef
,
// Required Magic Number
version
:
22800
,
// NOTE: This needs to be updated whenever we update the NCCL
version
.
version
:
nccl_
version
,
blocking
:
1
,
cgaClusterSize
:
i32
::
MIN
,
minCTAs
:
1
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment